]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
libnet4: Call map_netlogon_samlogon_response directly
authorVolker Lendecke <vl@samba.org>
Tue, 29 Oct 2024 08:01:43 +0000 (09:01 +0100)
committerVolker Lendecke <vl@samba.org>
Mon, 11 Nov 2024 14:03:03 +0000 (14:03 +0000)
Avoid using a boolean flag passed down

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
source4/libnet/libnet_become_dc.c

index f7da0cc777dc8418ef4db0a765791aedb9373e67..c429b96bdfc3ebeec956f8ddc17333ce5be640c7 100644 (file)
@@ -763,7 +763,6 @@ static void becomeDC_send_cldap(struct libnet_BecomeDC_state *s)
        s->cldap.io.in.domain_sid       = NULL;
        s->cldap.io.in.acct_control     = -1;
        s->cldap.io.in.version          = NETLOGON_NT_VERSION_5 | NETLOGON_NT_VERSION_5EX;
-       s->cldap.io.in.map_response     = true;
 
        ret = tsocket_address_inet_from_strings(s, "ip",
                                                s->source_dsa.address,
@@ -800,6 +799,8 @@ static void becomeDC_recv_cldap(struct tevent_req *req)
                         nt_errstr(c->status)));
                return;
        }
+
+       map_netlogon_samlogon_response(&s->cldap.io.out.netlogon);
        s->cldap.netlogon = s->cldap.io.out.netlogon.data.nt5_ex;
 
        s->domain.dns_name              = s->cldap.netlogon.dns_domain;