Author: Christos Tsantilas <chtsanti@users.sourceforge.net>

Bug 2400: ICAP accept mechanism assumes okay result

ACL checks produces an ACCESS_REQ_PROXY_AUTH result but ICAP
result handler assumes any non-zero result means ACCESS_ALLOWED

This can result in many requests being shunted to ICAP incorrently.

diff --git a/src/adaptation/AccessCheck.cc b/src/adaptation/AccessCheck.cc
index 4e6b2ff883eff195688bdfbcaad6214da2b3087e..870f610e778d6922c812b9277253bb3e4df8de7c 100644 (file)
--- a/src/adaptation/AccessCheck.cc
+++ b/src/adaptation/AccessCheck.cc
@@ -123,7 +123,7 @@ Adaptation::AccessCheck::AccessCheckCallbackWrapper(int answer, void *data)
 {
     debugs(93, 8, "AccessCheckCallbackWrapper: answer=" << answer);
     AccessCheck *ac = (AccessCheck*)data;
-    ac->noteAnswer(answer);
+    ac->noteAnswer(answer==ACCESS_ALLOWED);
 }
 
 void