]> git.ipfire.org Git - thirdparty/git.git/commitdiff
pack-bitmap.c: break out of the bitmap loop early if not tracing
authorJeff King <peff@peff.net>
Mon, 28 Nov 2022 14:09:52 +0000 (22:09 +0800)
committerJunio C Hamano <gitster@pobox.com>
Tue, 29 Nov 2022 00:54:56 +0000 (09:54 +0900)
After opening a bitmap successfully, we try opening others only
because we want to report that other bitmap files are ignored in
the trace2 log.  When trace2 is not enabled, we do not have to
do any of that.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Teng Long <dyroneteng@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
pack-bitmap.c

index aaa2d9a10498a7bfd0da40b90ec8826ee6d7efcd..3b6c2f804a3de648d5d42bdab8a6a3cdec1f39ec 100644 (file)
@@ -527,8 +527,15 @@ static int open_pack_bitmap(struct repository *r,
        assert(!bitmap_git->map);
 
        for (p = get_all_packs(r); p; p = p->next) {
-               if (open_pack_bitmap_1(bitmap_git, p) == 0)
+               if (open_pack_bitmap_1(bitmap_git, p) == 0) {
                        ret = 0;
+                       /*
+                        * The only reason to keep looking is to report
+                        * duplicates.
+                        */
+                       if (!trace2_is_enabled())
+                               break;
+               }
        }
 
        return ret;