]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
4.19-stable patches
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 23 Jul 2019 09:51:22 +0000 (11:51 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 23 Jul 2019 09:51:22 +0000 (11:51 +0200)
added patches:
arm64-tegra-update-jetson-tx1-gpu-regulator-timings.patch
bcache-destroy-dc-writeback_write_wq-if-failed-to-create-dc-writeback_thread.patch
bcache-fix-mistaken-sysfs-entry-for-io_error-counter.patch
bcache-ignore-read-ahead-request-failure-on-backing-device.patch
bcache-revert-bcache-fix-high-cpu-occupancy-during-journal.patch
bcache-revert-bcache-free-heap-cache_set-flush_btree-in-bch_journal_free.patch
cifs-flush-before-set-info-if-we-have-writeable-handles.patch
input-alps-don-t-handle-alps-cs19-trackpoint-only-device.patch
input-alps-fix-a-mismatch-between-a-condition-check-and-its-comment.patch
input-gtco-bounds-check-collection-indent-level.patch
input-synaptics-whitelist-lenovo-t580-smbus-intertouch.patch
iwlwifi-don-t-warn-when-calling-iwl_get_shared_mem_conf-with-rf-kill.patch
iwlwifi-fix-rf-kill-interrupt-while-fw-load-for-gen2-devices.patch
iwlwifi-pcie-don-t-service-an-interrupt-that-was-masked.patch
iwlwifi-pcie-fix-alive-interrupt-handling-for-gen2-devices-w-o-msi-x.patch
regulator-s2mps11-fix-buck7-and-buck8-wrong-voltages.patch
revert-bcache-set-cache_set_io_disable-in-bch_cached_dev_error.patch

18 files changed:
queue-4.19/arm64-tegra-update-jetson-tx1-gpu-regulator-timings.patch [new file with mode: 0644]
queue-4.19/bcache-destroy-dc-writeback_write_wq-if-failed-to-create-dc-writeback_thread.patch [new file with mode: 0644]
queue-4.19/bcache-fix-mistaken-sysfs-entry-for-io_error-counter.patch [new file with mode: 0644]
queue-4.19/bcache-ignore-read-ahead-request-failure-on-backing-device.patch [new file with mode: 0644]
queue-4.19/bcache-revert-bcache-fix-high-cpu-occupancy-during-journal.patch [new file with mode: 0644]
queue-4.19/bcache-revert-bcache-free-heap-cache_set-flush_btree-in-bch_journal_free.patch [new file with mode: 0644]
queue-4.19/cifs-flush-before-set-info-if-we-have-writeable-handles.patch [new file with mode: 0644]
queue-4.19/input-alps-don-t-handle-alps-cs19-trackpoint-only-device.patch [new file with mode: 0644]
queue-4.19/input-alps-fix-a-mismatch-between-a-condition-check-and-its-comment.patch [new file with mode: 0644]
queue-4.19/input-gtco-bounds-check-collection-indent-level.patch [new file with mode: 0644]
queue-4.19/input-synaptics-whitelist-lenovo-t580-smbus-intertouch.patch [new file with mode: 0644]
queue-4.19/iwlwifi-don-t-warn-when-calling-iwl_get_shared_mem_conf-with-rf-kill.patch [new file with mode: 0644]
queue-4.19/iwlwifi-fix-rf-kill-interrupt-while-fw-load-for-gen2-devices.patch [new file with mode: 0644]
queue-4.19/iwlwifi-pcie-don-t-service-an-interrupt-that-was-masked.patch [new file with mode: 0644]
queue-4.19/iwlwifi-pcie-fix-alive-interrupt-handling-for-gen2-devices-w-o-msi-x.patch [new file with mode: 0644]
queue-4.19/regulator-s2mps11-fix-buck7-and-buck8-wrong-voltages.patch [new file with mode: 0644]
queue-4.19/revert-bcache-set-cache_set_io_disable-in-bch_cached_dev_error.patch [new file with mode: 0644]
queue-4.19/series

diff --git a/queue-4.19/arm64-tegra-update-jetson-tx1-gpu-regulator-timings.patch b/queue-4.19/arm64-tegra-update-jetson-tx1-gpu-regulator-timings.patch
new file mode 100644 (file)
index 0000000..d80ab80
--- /dev/null
@@ -0,0 +1,38 @@
+From ece6031ece2dd64d63708cfe1088016cee5b10c0 Mon Sep 17 00:00:00 2001
+From: Jon Hunter <jonathanh@nvidia.com>
+Date: Thu, 20 Jun 2019 09:17:01 +0100
+Subject: arm64: tegra: Update Jetson TX1 GPU regulator timings
+
+From: Jon Hunter <jonathanh@nvidia.com>
+
+commit ece6031ece2dd64d63708cfe1088016cee5b10c0 upstream.
+
+The GPU regulator enable ramp delay for Jetson TX1 is set to 1ms which
+not sufficient because the enable ramp delay has been measured to be
+greater than 1ms. Furthermore, the downstream kernels released by NVIDIA
+for Jetson TX1 are using a enable ramp delay 2ms and a settling delay of
+160us. Update the GPU regulator enable ramp delay for Jetson TX1 to be
+2ms and add a settling delay of 160us.
+
+Cc: stable@vger.kernel.org
+Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
+Fixes: 5e6b9a89afce ("arm64: tegra: Add VDD_GPU regulator to Jetson TX1")
+Signed-off-by: Thierry Reding <treding@nvidia.com>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi |    3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+--- a/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi
++++ b/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi
+@@ -330,7 +330,8 @@
+                       regulator-max-microvolt = <1320000>;
+                       enable-gpios = <&pmic 6 GPIO_ACTIVE_HIGH>;
+                       regulator-ramp-delay = <80>;
+-                      regulator-enable-ramp-delay = <1000>;
++                      regulator-enable-ramp-delay = <2000>;
++                      regulator-settling-time-us = <160>;
+               };
+       };
+ };
diff --git a/queue-4.19/bcache-destroy-dc-writeback_write_wq-if-failed-to-create-dc-writeback_thread.patch b/queue-4.19/bcache-destroy-dc-writeback_write_wq-if-failed-to-create-dc-writeback_thread.patch
new file mode 100644 (file)
index 0000000..94fbdd0
--- /dev/null
@@ -0,0 +1,36 @@
+From f54d801dda14942dbefa00541d10603015b7859c Mon Sep 17 00:00:00 2001
+From: Coly Li <colyli@suse.de>
+Date: Fri, 28 Jun 2019 19:59:44 +0800
+Subject: bcache: destroy dc->writeback_write_wq if failed to create dc->writeback_thread
+
+From: Coly Li <colyli@suse.de>
+
+commit f54d801dda14942dbefa00541d10603015b7859c upstream.
+
+Commit 9baf30972b55 ("bcache: fix for gc and write-back race") added a
+new work queue dc->writeback_write_wq, but forgot to destroy it in the
+error condition when creating dc->writeback_thread failed.
+
+This patch destroys dc->writeback_write_wq if kthread_create() returns
+error pointer to dc->writeback_thread, then a memory leak is avoided.
+
+Fixes: 9baf30972b55 ("bcache: fix for gc and write-back race")
+Signed-off-by: Coly Li <colyli@suse.de>
+Cc: stable@vger.kernel.org
+Signed-off-by: Jens Axboe <axboe@kernel.dk>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ drivers/md/bcache/writeback.c |    1 +
+ 1 file changed, 1 insertion(+)
+
+--- a/drivers/md/bcache/writeback.c
++++ b/drivers/md/bcache/writeback.c
+@@ -807,6 +807,7 @@ int bch_cached_dev_writeback_start(struc
+                                             "bcache_writeback");
+       if (IS_ERR(dc->writeback_thread)) {
+               cached_dev_put(dc);
++              destroy_workqueue(dc->writeback_write_wq);
+               return PTR_ERR(dc->writeback_thread);
+       }
diff --git a/queue-4.19/bcache-fix-mistaken-sysfs-entry-for-io_error-counter.patch b/queue-4.19/bcache-fix-mistaken-sysfs-entry-for-io_error-counter.patch
new file mode 100644 (file)
index 0000000..bb32745
--- /dev/null
@@ -0,0 +1,45 @@
+From 5461999848e0462c14f306a62923d22de820a59c Mon Sep 17 00:00:00 2001
+From: Coly Li <colyli@suse.de>
+Date: Fri, 28 Jun 2019 19:59:43 +0800
+Subject: bcache: fix mistaken sysfs entry for io_error counter
+
+From: Coly Li <colyli@suse.de>
+
+commit 5461999848e0462c14f306a62923d22de820a59c upstream.
+
+In bch_cached_dev_files[] from driver/md/bcache/sysfs.c, sysfs_errors is
+incorrectly inserted in. The correct entry should be sysfs_io_errors.
+
+This patch fixes the problem and now I/O errors of cached device can be
+read from /sys/block/bcache<N>/bcache/io_errors.
+
+Fixes: c7b7bd07404c5 ("bcache: add io_disable to struct cached_dev")
+Signed-off-by: Coly Li <colyli@suse.de>
+Cc: stable@vger.kernel.org
+Signed-off-by: Jens Axboe <axboe@kernel.dk>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ drivers/md/bcache/sysfs.c |    4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+--- a/drivers/md/bcache/sysfs.c
++++ b/drivers/md/bcache/sysfs.c
+@@ -175,7 +175,7 @@ SHOW(__bch_cached_dev)
+       var_print(writeback_percent);
+       sysfs_hprint(writeback_rate,
+                    wb ? atomic_long_read(&dc->writeback_rate.rate) << 9 : 0);
+-      sysfs_hprint(io_errors,         atomic_read(&dc->io_errors));
++      sysfs_printf(io_errors,         "%i", atomic_read(&dc->io_errors));
+       sysfs_printf(io_error_limit,    "%i", dc->error_limit);
+       sysfs_printf(io_disable,        "%i", dc->io_disable);
+       var_print(writeback_rate_update_seconds);
+@@ -426,7 +426,7 @@ static struct attribute *bch_cached_dev_
+       &sysfs_writeback_rate_p_term_inverse,
+       &sysfs_writeback_rate_minimum,
+       &sysfs_writeback_rate_debug,
+-      &sysfs_errors,
++      &sysfs_io_errors,
+       &sysfs_io_error_limit,
+       &sysfs_io_disable,
+       &sysfs_dirty_data,
diff --git a/queue-4.19/bcache-ignore-read-ahead-request-failure-on-backing-device.patch b/queue-4.19/bcache-ignore-read-ahead-request-failure-on-backing-device.patch
new file mode 100644 (file)
index 0000000..b1e6599
--- /dev/null
@@ -0,0 +1,57 @@
+From 578df99b1b0531d19af956530fe4da63d01a1604 Mon Sep 17 00:00:00 2001
+From: Coly Li <colyli@suse.de>
+Date: Fri, 28 Jun 2019 19:59:29 +0800
+Subject: bcache: ignore read-ahead request failure on backing device
+
+From: Coly Li <colyli@suse.de>
+
+commit 578df99b1b0531d19af956530fe4da63d01a1604 upstream.
+
+When md raid device (e.g. raid456) is used as backing device, read-ahead
+requests on a degrading and recovering md raid device might be failured
+immediately by md raid code, but indeed this md raid array can still be
+read or write for normal I/O requests. Therefore such failed read-ahead
+request are not real hardware failure. Further more, after degrading and
+recovering accomplished, read-ahead requests will be handled by md raid
+array again.
+
+For such condition, I/O failures of read-ahead requests don't indicate
+real health status (because normal I/O still be served), they should not
+be counted into I/O error counter dc->io_errors.
+
+Since there is no simple way to detect whether the backing divice is a
+md raid device, this patch simply ignores I/O failures for read-ahead
+bios on backing device, to avoid bogus backing device failure on a
+degrading md raid array.
+
+Suggested-and-tested-by: Thorsten Knabe <linux@thorsten-knabe.de>
+Signed-off-by: Coly Li <colyli@suse.de>
+Cc: stable@vger.kernel.org
+Signed-off-by: Jens Axboe <axboe@kernel.dk>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ drivers/md/bcache/io.c |   12 ++++++++++++
+ 1 file changed, 12 insertions(+)
+
+--- a/drivers/md/bcache/io.c
++++ b/drivers/md/bcache/io.c
+@@ -58,6 +58,18 @@ void bch_count_backing_io_errors(struct
+       WARN_ONCE(!dc, "NULL pointer of struct cached_dev");
++      /*
++       * Read-ahead requests on a degrading and recovering md raid
++       * (e.g. raid6) device might be failured immediately by md
++       * raid code, which is not a real hardware media failure. So
++       * we shouldn't count failed REQ_RAHEAD bio to dc->io_errors.
++       */
++      if (bio->bi_opf & REQ_RAHEAD) {
++              pr_warn_ratelimited("%s: Read-ahead I/O failed on backing device, ignore",
++                                  dc->backing_dev_name);
++              return;
++      }
++
+       errors = atomic_add_return(1, &dc->io_errors);
+       if (errors < dc->error_limit)
+               pr_err("%s: IO error on backing device, unrecoverable",
diff --git a/queue-4.19/bcache-revert-bcache-fix-high-cpu-occupancy-during-journal.patch b/queue-4.19/bcache-revert-bcache-fix-high-cpu-occupancy-during-journal.patch
new file mode 100644 (file)
index 0000000..a284b9f
--- /dev/null
@@ -0,0 +1,126 @@
+From 249a5f6da57c28a903c75d81505d58ec8c10030d Mon Sep 17 00:00:00 2001
+From: Coly Li <colyli@suse.de>
+Date: Fri, 28 Jun 2019 19:59:54 +0800
+Subject: bcache: Revert "bcache: fix high CPU occupancy during journal"
+
+From: Coly Li <colyli@suse.de>
+
+commit 249a5f6da57c28a903c75d81505d58ec8c10030d upstream.
+
+This reverts commit c4dc2497d50d9c6fb16aa0d07b6a14f3b2adb1e0.
+
+This patch enlarges a race between normal btree flush code path and
+flush_btree_write(), which causes deadlock when journal space is
+exhausted. Reverts this patch makes the race window from 128 btree
+nodes to only 1 btree nodes.
+
+Fixes: c4dc2497d50d ("bcache: fix high CPU occupancy during journal")
+Signed-off-by: Coly Li <colyli@suse.de>
+Cc: stable@vger.kernel.org
+Cc: Tang Junhui <tang.junhui.linux@gmail.com>
+Signed-off-by: Jens Axboe <axboe@kernel.dk>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ drivers/md/bcache/bcache.h  |    2 -
+ drivers/md/bcache/journal.c |   47 ++++++++++++++------------------------------
+ drivers/md/bcache/util.h    |    2 -
+ 3 files changed, 15 insertions(+), 36 deletions(-)
+
+--- a/drivers/md/bcache/bcache.h
++++ b/drivers/md/bcache/bcache.h
+@@ -708,8 +708,6 @@ struct cache_set {
+ #define BUCKET_HASH_BITS      12
+       struct hlist_head       bucket_hash[1 << BUCKET_HASH_BITS];
+-
+-      DECLARE_HEAP(struct btree *, flush_btree);
+ };
+ struct bbio {
+--- a/drivers/md/bcache/journal.c
++++ b/drivers/md/bcache/journal.c
+@@ -390,12 +390,6 @@ err:
+ }
+ /* Journalling */
+-#define journal_max_cmp(l, r) \
+-      (fifo_idx(&c->journal.pin, btree_current_write(l)->journal) < \
+-       fifo_idx(&(c)->journal.pin, btree_current_write(r)->journal))
+-#define journal_min_cmp(l, r) \
+-      (fifo_idx(&c->journal.pin, btree_current_write(l)->journal) > \
+-       fifo_idx(&(c)->journal.pin, btree_current_write(r)->journal))
+ static void btree_flush_write(struct cache_set *c)
+ {
+@@ -403,35 +397,25 @@ static void btree_flush_write(struct cac
+        * Try to find the btree node with that references the oldest journal
+        * entry, best is our current candidate and is locked if non NULL:
+        */
+-      struct btree *b;
+-      int i;
++      struct btree *b, *best;
++      unsigned int i;
+       atomic_long_inc(&c->flush_write);
+-
+ retry:
+-      spin_lock(&c->journal.lock);
+-      if (heap_empty(&c->flush_btree)) {
+-              for_each_cached_btree(b, c, i)
+-                      if (btree_current_write(b)->journal) {
+-                              if (!heap_full(&c->flush_btree))
+-                                      heap_add(&c->flush_btree, b,
+-                                               journal_max_cmp);
+-                              else if (journal_max_cmp(b,
+-                                       heap_peek(&c->flush_btree))) {
+-                                      c->flush_btree.data[0] = b;
+-                                      heap_sift(&c->flush_btree, 0,
+-                                                journal_max_cmp);
+-                              }
+-                      }
+-
+-              for (i = c->flush_btree.used / 2 - 1; i >= 0; --i)
+-                      heap_sift(&c->flush_btree, i, journal_min_cmp);
+-      }
++      best = NULL;
+-      b = NULL;
+-      heap_pop(&c->flush_btree, b, journal_min_cmp);
+-      spin_unlock(&c->journal.lock);
++      for_each_cached_btree(b, c, i)
++              if (btree_current_write(b)->journal) {
++                      if (!best)
++                              best = b;
++                      else if (journal_pin_cmp(c,
++                                      btree_current_write(best)->journal,
++                                      btree_current_write(b)->journal)) {
++                              best = b;
++                      }
++              }
++      b = best;
+       if (b) {
+               mutex_lock(&b->write_lock);
+               if (!btree_current_write(b)->journal) {
+@@ -873,8 +857,7 @@ int bch_journal_alloc(struct cache_set *
+       j->w[0].c = c;
+       j->w[1].c = c;
+-      if (!(init_heap(&c->flush_btree, 128, GFP_KERNEL)) ||
+-          !(init_fifo(&j->pin, JOURNAL_PIN, GFP_KERNEL)) ||
++      if (!(init_fifo(&j->pin, JOURNAL_PIN, GFP_KERNEL)) ||
+           !(j->w[0].data = (void *) __get_free_pages(GFP_KERNEL, JSET_BITS)) ||
+           !(j->w[1].data = (void *) __get_free_pages(GFP_KERNEL, JSET_BITS)))
+               return -ENOMEM;
+--- a/drivers/md/bcache/util.h
++++ b/drivers/md/bcache/util.h
+@@ -113,8 +113,6 @@ do {                                                                       \
+ #define heap_full(h)  ((h)->used == (h)->size)
+-#define heap_empty(h) ((h)->used == 0)
+-
+ #define DECLARE_FIFO(type, name)                                      \
+       struct {                                                        \
+               size_t front, back, size, mask;                         \
diff --git a/queue-4.19/bcache-revert-bcache-free-heap-cache_set-flush_btree-in-bch_journal_free.patch b/queue-4.19/bcache-revert-bcache-free-heap-cache_set-flush_btree-in-bch_journal_free.patch
new file mode 100644 (file)
index 0000000..4b00294
--- /dev/null
@@ -0,0 +1,36 @@
+From ba82c1ac1667d6efb91a268edb13fc9cdaecec9b Mon Sep 17 00:00:00 2001
+From: Coly Li <colyli@suse.de>
+Date: Fri, 28 Jun 2019 19:59:53 +0800
+Subject: bcache: Revert "bcache: free heap cache_set->flush_btree in bch_journal_free"
+
+From: Coly Li <colyli@suse.de>
+
+commit ba82c1ac1667d6efb91a268edb13fc9cdaecec9b upstream.
+
+This reverts commit 6268dc2c4703aabfb0b35681be709acf4c2826c6.
+
+This patch depends on commit c4dc2497d50d ("bcache: fix high CPU
+occupancy during journal") which is reverted in previous patch. So
+revert this one too.
+
+Fixes: 6268dc2c4703 ("bcache: free heap cache_set->flush_btree in bch_journal_free")
+Signed-off-by: Coly Li <colyli@suse.de>
+Cc: stable@vger.kernel.org
+Cc: Shenghui Wang <shhuiw@foxmail.com>
+Signed-off-by: Jens Axboe <axboe@kernel.dk>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ drivers/md/bcache/journal.c |    1 -
+ 1 file changed, 1 deletion(-)
+
+--- a/drivers/md/bcache/journal.c
++++ b/drivers/md/bcache/journal.c
+@@ -842,7 +842,6 @@ void bch_journal_free(struct cache_set *
+       free_pages((unsigned long) c->journal.w[1].data, JSET_BITS);
+       free_pages((unsigned long) c->journal.w[0].data, JSET_BITS);
+       free_fifo(&c->journal.pin);
+-      free_heap(&c->flush_btree);
+ }
+ int bch_journal_alloc(struct cache_set *c)
diff --git a/queue-4.19/cifs-flush-before-set-info-if-we-have-writeable-handles.patch b/queue-4.19/cifs-flush-before-set-info-if-we-have-writeable-handles.patch
new file mode 100644 (file)
index 0000000..272b3d4
--- /dev/null
@@ -0,0 +1,61 @@
+From aa081859b10c5d8b19f5c525c78883a59d73c2b8 Mon Sep 17 00:00:00 2001
+From: Ronnie Sahlberg <lsahlber@redhat.com>
+Date: Fri, 19 Jul 2019 08:12:11 +1000
+Subject: cifs: flush before set-info if we have writeable handles
+
+From: Ronnie Sahlberg <lsahlber@redhat.com>
+
+commit aa081859b10c5d8b19f5c525c78883a59d73c2b8 upstream.
+
+Servers can defer destaging any data and updating the mtime until close().
+This means that if we do a setinfo to modify the mtime while other handles
+are open for write the server may overwrite our setinfo timestamps when
+if flushes the file on close() of the writeable handle.
+
+To solve this we add an explicit flush when the mtime is about to
+be updated.
+
+This fixes "cp -p" to preserve mtime when copying a file onto an SMB2 share.
+
+CC: Stable <stable@vger.kernel.org>
+Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
+Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com>
+Signed-off-by: Steve French <stfrench@microsoft.com>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ fs/cifs/inode.c |   16 ++++++++++++++++
+ 1 file changed, 16 insertions(+)
+
+--- a/fs/cifs/inode.c
++++ b/fs/cifs/inode.c
+@@ -2366,6 +2366,8 @@ cifs_setattr_nounix(struct dentry *diren
+       struct inode *inode = d_inode(direntry);
+       struct cifs_sb_info *cifs_sb = CIFS_SB(inode->i_sb);
+       struct cifsInodeInfo *cifsInode = CIFS_I(inode);
++      struct cifsFileInfo *wfile;
++      struct cifs_tcon *tcon;
+       char *full_path = NULL;
+       int rc = -EACCES;
+       __u32 dosattr = 0;
+@@ -2407,6 +2409,20 @@ cifs_setattr_nounix(struct dentry *diren
+       mapping_set_error(inode->i_mapping, rc);
+       rc = 0;
++      if (attrs->ia_valid & ATTR_MTIME) {
++              rc = cifs_get_writable_file(cifsInode, false, &wfile);
++              if (!rc) {
++                      tcon = tlink_tcon(wfile->tlink);
++                      rc = tcon->ses->server->ops->flush(xid, tcon, &wfile->fid);
++                      cifsFileInfo_put(wfile);
++                      if (rc)
++                              return rc;
++              } else if (rc != -EBADF)
++                      return rc;
++              else
++                      rc = 0;
++      }
++
+       if (attrs->ia_valid & ATTR_SIZE) {
+               rc = cifs_set_file_size(inode, attrs, xid, full_path);
+               if (rc != 0)
diff --git a/queue-4.19/input-alps-don-t-handle-alps-cs19-trackpoint-only-device.patch b/queue-4.19/input-alps-don-t-handle-alps-cs19-trackpoint-only-device.patch
new file mode 100644 (file)
index 0000000..0f813e4
--- /dev/null
@@ -0,0 +1,101 @@
+From 7e4935ccc3236751e5fe4bd6846f86e46bb2e427 Mon Sep 17 00:00:00 2001
+From: Hui Wang <hui.wang@canonical.com>
+Date: Mon, 15 Jul 2019 10:00:58 -0700
+Subject: Input: alps - don't handle ALPS cs19 trackpoint-only device
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+From: Hui Wang <hui.wang@canonical.com>
+
+commit 7e4935ccc3236751e5fe4bd6846f86e46bb2e427 upstream.
+
+On a latest Lenovo laptop, the trackpoint and 3 buttons below it
+don't work at all, when we move the trackpoint or press those 3
+buttons, the kernel will print out:
+"Rejected trackstick packet from non DualPoint device"
+
+This device is identified as an alps touchpad but the packet has
+trackpoint format, so the alps.c drops the packet and prints out
+the message above.
+
+According to XiaoXiao's explanation, this device is named cs19 and
+is trackpoint-only device, its firmware is only for trackpoint, it
+is independent of touchpad and is a device completely different from
+DualPoint ones.
+
+To drive this device with mininal changes to the existing driver, we
+just let the alps driver not handle this device, then the trackpoint.c
+will be the driver of this device if the trackpoint driver is enabled.
+(if not, this device will fallback to a bare PS/2 device)
+
+With the trackpoint.c, this trackpoint and 3 buttons all work well,
+they have all features that the trackpoint should have, like
+scrolling-screen, drag-and-drop and frame-selection.
+
+Signed-off-by: XiaoXiao Liu <sliuuxiaonxiao@gmail.com>
+Signed-off-by: Hui Wang <hui.wang@canonical.com>
+Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
+Cc: stable@vger.kernel.org
+Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ drivers/input/mouse/alps.c |   32 ++++++++++++++++++++++++++++++++
+ 1 file changed, 32 insertions(+)
+
+--- a/drivers/input/mouse/alps.c
++++ b/drivers/input/mouse/alps.c
+@@ -24,6 +24,7 @@
+ #include "psmouse.h"
+ #include "alps.h"
++#include "trackpoint.h"
+ /*
+  * Definitions for ALPS version 3 and 4 command mode protocol
+@@ -2864,6 +2865,23 @@ static const struct alps_protocol_info *
+       return NULL;
+ }
++static bool alps_is_cs19_trackpoint(struct psmouse *psmouse)
++{
++      u8 param[2] = { 0 };
++
++      if (ps2_command(&psmouse->ps2dev,
++                      param, MAKE_PS2_CMD(0, 2, TP_READ_ID)))
++              return false;
++
++      /*
++       * param[0] contains the trackpoint device variant_id while
++       * param[1] contains the firmware_id. So far all alps
++       * trackpoint-only devices have their variant_ids equal
++       * TP_VARIANT_ALPS and their firmware_ids are in 0x20~0x2f range.
++       */
++      return param[0] == TP_VARIANT_ALPS && (param[1] & 0x20);
++}
++
+ static int alps_identify(struct psmouse *psmouse, struct alps_data *priv)
+ {
+       const struct alps_protocol_info *protocol;
+@@ -3165,6 +3183,20 @@ int alps_detect(struct psmouse *psmouse,
+               return error;
+       /*
++       * ALPS cs19 is a trackpoint-only device, and uses different
++       * protocol than DualPoint ones, so we return -EINVAL here and let
++       * trackpoint.c drive this device. If the trackpoint driver is not
++       * enabled, the device will fall back to a bare PS/2 mouse.
++       * If ps2_command() fails here, we depend on the immediately
++       * followed psmouse_reset() to reset the device to normal state.
++       */
++      if (alps_is_cs19_trackpoint(psmouse)) {
++              psmouse_dbg(psmouse,
++                          "ALPS CS19 trackpoint-only device detected, ignoring\n");
++              return -EINVAL;
++      }
++
++      /*
+        * Reset the device to make sure it is fully operational:
+        * on some laptops, like certain Dell Latitudes, we may
+        * fail to properly detect presence of trackstick if device
diff --git a/queue-4.19/input-alps-fix-a-mismatch-between-a-condition-check-and-its-comment.patch b/queue-4.19/input-alps-fix-a-mismatch-between-a-condition-check-and-its-comment.patch
new file mode 100644 (file)
index 0000000..3c4c45c
--- /dev/null
@@ -0,0 +1,38 @@
+From 771a081e44a9baa1991ef011cc453ef425591740 Mon Sep 17 00:00:00 2001
+From: Hui Wang <hui.wang@canonical.com>
+Date: Fri, 19 Jul 2019 12:38:58 +0300
+Subject: Input: alps - fix a mismatch between a condition check and its comment
+
+From: Hui Wang <hui.wang@canonical.com>
+
+commit 771a081e44a9baa1991ef011cc453ef425591740 upstream.
+
+In the function alps_is_cs19_trackpoint(), we check if the param[1] is
+in the 0x20~0x2f range, but the code we wrote for this checking is not
+correct:
+(param[1] & 0x20) does not mean param[1] is in the range of 0x20~0x2f,
+it also means the param[1] is in the range of 0x30~0x3f, 0x60~0x6f...
+
+Now fix it with a new condition checking ((param[1] & 0xf0) == 0x20).
+
+Fixes: 7e4935ccc323 ("Input: alps - don't handle ALPS cs19 trackpoint-only device")
+Cc: stable@vger.kernel.org
+Signed-off-by: Hui Wang <hui.wang@canonical.com>
+Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ drivers/input/mouse/alps.c |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+--- a/drivers/input/mouse/alps.c
++++ b/drivers/input/mouse/alps.c
+@@ -2879,7 +2879,7 @@ static bool alps_is_cs19_trackpoint(stru
+        * trackpoint-only devices have their variant_ids equal
+        * TP_VARIANT_ALPS and their firmware_ids are in 0x20~0x2f range.
+        */
+-      return param[0] == TP_VARIANT_ALPS && (param[1] & 0x20);
++      return param[0] == TP_VARIANT_ALPS && ((param[1] & 0xf0) == 0x20);
+ }
+ static int alps_identify(struct psmouse *psmouse, struct alps_data *priv)
diff --git a/queue-4.19/input-gtco-bounds-check-collection-indent-level.patch b/queue-4.19/input-gtco-bounds-check-collection-indent-level.patch
new file mode 100644 (file)
index 0000000..29900e9
--- /dev/null
@@ -0,0 +1,79 @@
+From 2a017fd82c5402b3c8df5e3d6e5165d9e6147dc1 Mon Sep 17 00:00:00 2001
+From: Grant Hernandez <granthernandez@google.com>
+Date: Sat, 13 Jul 2019 01:00:12 -0700
+Subject: Input: gtco - bounds check collection indent level
+
+From: Grant Hernandez <granthernandez@google.com>
+
+commit 2a017fd82c5402b3c8df5e3d6e5165d9e6147dc1 upstream.
+
+The GTCO tablet input driver configures itself from an HID report sent
+via USB during the initial enumeration process. Some debugging messages
+are generated during the parsing. A debugging message indentation
+counter is not bounds checked, leading to the ability for a specially
+crafted HID report to cause '-' and null bytes be written past the end
+of the indentation array. As long as the kernel has CONFIG_DYNAMIC_DEBUG
+enabled, this code will not be optimized out.  This was discovered
+during code review after a previous syzkaller bug was found in this
+driver.
+
+Signed-off-by: Grant Hernandez <granthernandez@google.com>
+Cc: stable@vger.kernel.org
+Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ drivers/input/tablet/gtco.c |   20 +++++++++++++++++---
+ 1 file changed, 17 insertions(+), 3 deletions(-)
+
+--- a/drivers/input/tablet/gtco.c
++++ b/drivers/input/tablet/gtco.c
+@@ -78,6 +78,7 @@ Scott Hill shill@gtcocalcomp.com
+ /* Max size of a single report */
+ #define REPORT_MAX_SIZE       10
++#define MAX_COLLECTION_LEVELS  10
+ /* Bitmask whether pen is in range */
+@@ -223,8 +224,7 @@ static void parse_hid_report_descriptor(
+       char  maintype = 'x';
+       char  globtype[12];
+       int   indent = 0;
+-      char  indentstr[10] = "";
+-
++      char  indentstr[MAX_COLLECTION_LEVELS + 1] = { 0 };
+       dev_dbg(ddev, "======>>>>>>PARSE<<<<<<======\n");
+@@ -350,6 +350,13 @@ static void parse_hid_report_descriptor(
+                       case TAG_MAIN_COL_START:
+                               maintype = 'S';
++                              if (indent == MAX_COLLECTION_LEVELS) {
++                                      dev_err(ddev, "Collection level %d would exceed limit of %d\n",
++                                              indent + 1,
++                                              MAX_COLLECTION_LEVELS);
++                                      break;
++                              }
++
+                               if (data == 0) {
+                                       dev_dbg(ddev, "======>>>>>> Physical\n");
+                                       strcpy(globtype, "Physical");
+@@ -369,8 +376,15 @@ static void parse_hid_report_descriptor(
+                               break;
+                       case TAG_MAIN_COL_END:
+-                              dev_dbg(ddev, "<<<<<<======\n");
+                               maintype = 'E';
++
++                              if (indent == 0) {
++                                      dev_err(ddev, "Collection level already at zero\n");
++                                      break;
++                              }
++
++                              dev_dbg(ddev, "<<<<<<======\n");
++
+                               indent--;
+                               for (x = 0; x < indent; x++)
+                                       indentstr[x] = '-';
diff --git a/queue-4.19/input-synaptics-whitelist-lenovo-t580-smbus-intertouch.patch b/queue-4.19/input-synaptics-whitelist-lenovo-t580-smbus-intertouch.patch
new file mode 100644 (file)
index 0000000..ed4323b
--- /dev/null
@@ -0,0 +1,32 @@
+From 1976d7d200c5a32e72293a2ada36b7b7c9d6dd6e Mon Sep 17 00:00:00 2001
+From: Nick Black <dankamongmen@gmail.com>
+Date: Thu, 11 Jul 2019 23:42:03 -0700
+Subject: Input: synaptics - whitelist Lenovo T580 SMBus intertouch
+
+From: Nick Black <dankamongmen@gmail.com>
+
+commit 1976d7d200c5a32e72293a2ada36b7b7c9d6dd6e upstream.
+
+Adds the Lenovo T580 to the SMBus intertouch list for Synaptics
+touchpads. I've tested with this for a week now, and it seems a great
+improvement. It's also nice to have the complaint gone from dmesg.
+
+Signed-off-by: Nick Black <dankamongmen@gmail.com>
+Cc: stable@vger.kernel.org
+Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ drivers/input/mouse/synaptics.c |    1 +
+ 1 file changed, 1 insertion(+)
+
+--- a/drivers/input/mouse/synaptics.c
++++ b/drivers/input/mouse/synaptics.c
+@@ -179,6 +179,7 @@ static const char * const smbus_pnp_ids[
+       "LEN0093", /* T480 */
+       "LEN0096", /* X280 */
+       "LEN0097", /* X280 -> ALPS trackpoint */
++      "LEN009b", /* T580 */
+       "LEN200f", /* T450s */
+       "LEN2054", /* E480 */
+       "LEN2055", /* E580 */
diff --git a/queue-4.19/iwlwifi-don-t-warn-when-calling-iwl_get_shared_mem_conf-with-rf-kill.patch b/queue-4.19/iwlwifi-don-t-warn-when-calling-iwl_get_shared_mem_conf-with-rf-kill.patch
new file mode 100644 (file)
index 0000000..9711a17
--- /dev/null
@@ -0,0 +1,66 @@
+From 0d53cfd0cca3c729a089c39eef0e7d8ae7662974 Mon Sep 17 00:00:00 2001
+From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
+Date: Wed, 22 May 2019 12:17:09 +0300
+Subject: iwlwifi: don't WARN when calling iwl_get_shared_mem_conf with RF-Kill
+
+From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
+
+commit 0d53cfd0cca3c729a089c39eef0e7d8ae7662974 upstream.
+
+iwl_mvm_send_cmd returns 0 when the command won't be sent
+because RF-Kill is asserted. Do the same when we call
+iwl_get_shared_mem_conf since it is not sent through
+iwl_mvm_send_cmd but directly calls the transport layer.
+
+Cc: stable@vger.kernel.org
+Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
+Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ drivers/net/wireless/intel/iwlwifi/fw/smem.c |   12 +++++++++---
+ 1 file changed, 9 insertions(+), 3 deletions(-)
+
+--- a/drivers/net/wireless/intel/iwlwifi/fw/smem.c
++++ b/drivers/net/wireless/intel/iwlwifi/fw/smem.c
+@@ -8,7 +8,7 @@
+  * Copyright(c) 2012 - 2014 Intel Corporation. All rights reserved.
+  * Copyright(c) 2013 - 2015 Intel Mobile Communications GmbH
+  * Copyright(c) 2016 - 2017 Intel Deutschland GmbH
+- * Copyright(c) 2018 Intel Corporation
++ * Copyright(c) 2018 - 2019 Intel Corporation
+  *
+  * This program is free software; you can redistribute it and/or modify
+  * it under the terms of version 2 of the GNU General Public License as
+@@ -31,7 +31,7 @@
+  * Copyright(c) 2012 - 2014 Intel Corporation. All rights reserved.
+  * Copyright(c) 2013 - 2015 Intel Mobile Communications GmbH
+  * Copyright(c) 2016 - 2017 Intel Deutschland GmbH
+- * Copyright(c) 2018 Intel Corporation
++ * Copyright(c) 2018 - 2019 Intel Corporation
+  * All rights reserved.
+  *
+  * Redistribution and use in source and binary forms, with or without
+@@ -134,6 +134,7 @@ void iwl_get_shared_mem_conf(struct iwl_
+               .len = { 0, },
+       };
+       struct iwl_rx_packet *pkt;
++      int ret;
+       if (fw_has_capa(&fwrt->fw->ucode_capa,
+                       IWL_UCODE_TLV_CAPA_EXTEND_SHARED_MEM_CFG))
+@@ -141,8 +142,13 @@ void iwl_get_shared_mem_conf(struct iwl_
+       else
+               cmd.id = SHARED_MEM_CFG;
+-      if (WARN_ON(iwl_trans_send_cmd(fwrt->trans, &cmd)))
++      ret = iwl_trans_send_cmd(fwrt->trans, &cmd);
++
++      if (ret) {
++              WARN(ret != -ERFKILL,
++                   "Could not send the SMEM command: %d\n", ret);
+               return;
++      }
+       pkt = cmd.resp_pkt;
+       if (fwrt->trans->cfg->device_family >= IWL_DEVICE_FAMILY_22000)
diff --git a/queue-4.19/iwlwifi-fix-rf-kill-interrupt-while-fw-load-for-gen2-devices.patch b/queue-4.19/iwlwifi-fix-rf-kill-interrupt-while-fw-load-for-gen2-devices.patch
new file mode 100644 (file)
index 0000000..1cd2efe
--- /dev/null
@@ -0,0 +1,148 @@
+From ed3e4c6d3cd8f093a3636cb05492429fe2af228d Mon Sep 17 00:00:00 2001
+From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
+Date: Mon, 20 May 2019 15:18:24 +0300
+Subject: iwlwifi: fix RF-Kill interrupt while FW load for gen2 devices
+
+From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
+
+commit ed3e4c6d3cd8f093a3636cb05492429fe2af228d upstream.
+
+Newest devices have a new firmware load mechanism. This
+mechanism is called the context info. It means that the
+driver doesn't need to load the sections of the firmware.
+The driver rather prepares a place in DRAM, with pointers
+to the relevant sections of the firmware, and the firmware
+loads itself.
+At the end of the process, the firmware sends the ALIVE
+interrupt. This is different from the previous scheme in
+which the driver expected the FH_TX interrupt after each
+section being transferred over the DMA.
+
+In order to support this new flow, we enabled all the
+interrupts. This broke the assumption that we have in the
+code that the RF-Kill interrupt can't interrupt the firmware
+load flow.
+
+Change the context info flow to enable only the ALIVE
+interrupt, and re-enable all the other interrupts only
+after the firmware is alive. Then, we won't see the RF-Kill
+interrupt until then. Getting the RF-Kill interrupt while
+loading the firmware made us kill the firmware while it is
+loading and we ended up dumping garbage instead of the firmware
+state.
+
+Re-enable the ALIVE | RX interrupts from the ISR when we
+get the ALIVE interrupt to be able to get the RX interrupt
+that comes immediately afterwards for the ALIVE
+notification. This is needed for non MSI-X only.
+
+Cc: stable@vger.kernel.org
+Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
+Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ drivers/net/wireless/intel/iwlwifi/pcie/ctxt-info-gen3.c |    2 -
+ drivers/net/wireless/intel/iwlwifi/pcie/ctxt-info.c      |    2 -
+ drivers/net/wireless/intel/iwlwifi/pcie/internal.h       |   27 +++++++++++++++
+ drivers/net/wireless/intel/iwlwifi/pcie/rx.c             |    5 ++
+ drivers/net/wireless/intel/iwlwifi/pcie/trans-gen2.c     |    9 +++++
+ 5 files changed, 43 insertions(+), 2 deletions(-)
+
+--- a/drivers/net/wireless/intel/iwlwifi/pcie/ctxt-info-gen3.c
++++ b/drivers/net/wireless/intel/iwlwifi/pcie/ctxt-info-gen3.c
+@@ -164,7 +164,7 @@ int iwl_pcie_ctxt_info_gen3_init(struct
+       memcpy(iml_img, trans->iml, trans->iml_len);
+-      iwl_enable_interrupts(trans);
++      iwl_enable_fw_load_int_ctx_info(trans);
+       /* kick FW self load */
+       iwl_write64(trans, CSR_CTXT_INFO_ADDR,
+--- a/drivers/net/wireless/intel/iwlwifi/pcie/ctxt-info.c
++++ b/drivers/net/wireless/intel/iwlwifi/pcie/ctxt-info.c
+@@ -206,7 +206,7 @@ int iwl_pcie_ctxt_info_init(struct iwl_t
+       trans_pcie->ctxt_info = ctxt_info;
+-      iwl_enable_interrupts(trans);
++      iwl_enable_fw_load_int_ctx_info(trans);
+       /* Configure debug, if exists */
+       if (trans->dbg_dest_tlv)
+--- a/drivers/net/wireless/intel/iwlwifi/pcie/internal.h
++++ b/drivers/net/wireless/intel/iwlwifi/pcie/internal.h
+@@ -896,6 +896,33 @@ static inline void iwl_enable_fw_load_in
+       }
+ }
++static inline void iwl_enable_fw_load_int_ctx_info(struct iwl_trans *trans)
++{
++      struct iwl_trans_pcie *trans_pcie = IWL_TRANS_GET_PCIE_TRANS(trans);
++
++      IWL_DEBUG_ISR(trans, "Enabling ALIVE interrupt only\n");
++
++      if (!trans_pcie->msix_enabled) {
++              /*
++               * When we'll receive the ALIVE interrupt, the ISR will call
++               * iwl_enable_fw_load_int_ctx_info again to set the ALIVE
++               * interrupt (which is not really needed anymore) but also the
++               * RX interrupt which will allow us to receive the ALIVE
++               * notification (which is Rx) and continue the flow.
++               */
++              trans_pcie->inta_mask =  CSR_INT_BIT_ALIVE | CSR_INT_BIT_FH_RX;
++              iwl_write32(trans, CSR_INT_MASK, trans_pcie->inta_mask);
++      } else {
++              iwl_enable_hw_int_msk_msix(trans,
++                                         MSIX_HW_INT_CAUSES_REG_ALIVE);
++              /*
++               * Leave all the FH causes enabled to get the ALIVE
++               * notification.
++               */
++              iwl_enable_fh_int_msk_msix(trans, trans_pcie->fh_init_mask);
++      }
++}
++
+ static inline u16 iwl_pcie_get_cmd_index(const struct iwl_txq *q, u32 index)
+ {
+       return index & (q->n_window - 1);
+--- a/drivers/net/wireless/intel/iwlwifi/pcie/rx.c
++++ b/drivers/net/wireless/intel/iwlwifi/pcie/rx.c
+@@ -1796,6 +1796,8 @@ irqreturn_t iwl_pcie_irq_handler(int irq
+                        */
+                       iwl_pcie_rxmq_restock(trans, trans_pcie->rxq);
+               }
++
++              handled |= CSR_INT_BIT_ALIVE;
+       }
+       /* Safely ignore these bits for debug checks below */
+@@ -1914,6 +1916,9 @@ irqreturn_t iwl_pcie_irq_handler(int irq
+       /* Re-enable RF_KILL if it occurred */
+       else if (handled & CSR_INT_BIT_RF_KILL)
+               iwl_enable_rfkill_int(trans);
++      /* Re-enable the ALIVE / Rx interrupt if it occurred */
++      else if (handled & (CSR_INT_BIT_ALIVE | CSR_INT_BIT_FH_RX))
++              iwl_enable_fw_load_int_ctx_info(trans);
+       spin_unlock(&trans_pcie->irq_lock);
+ out:
+--- a/drivers/net/wireless/intel/iwlwifi/pcie/trans-gen2.c
++++ b/drivers/net/wireless/intel/iwlwifi/pcie/trans-gen2.c
+@@ -289,6 +289,15 @@ void iwl_trans_pcie_gen2_fw_alive(struct
+        * paging memory cannot be freed included since FW will still use it
+        */
+       iwl_pcie_ctxt_info_free(trans);
++
++      /*
++       * Re-enable all the interrupts, including the RF-Kill one, now that
++       * the firmware is alive.
++       */
++      iwl_enable_interrupts(trans);
++      mutex_lock(&trans_pcie->mutex);
++      iwl_pcie_check_hw_rf_kill(trans);
++      mutex_unlock(&trans_pcie->mutex);
+ }
+ int iwl_trans_pcie_gen2_start_fw(struct iwl_trans *trans,
diff --git a/queue-4.19/iwlwifi-pcie-don-t-service-an-interrupt-that-was-masked.patch b/queue-4.19/iwlwifi-pcie-don-t-service-an-interrupt-that-was-masked.patch
new file mode 100644 (file)
index 0000000..dbb448e
--- /dev/null
@@ -0,0 +1,72 @@
+From 3b57a10ca14c619707398dc58fe5ece18c95b20b Mon Sep 17 00:00:00 2001
+From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
+Date: Tue, 21 May 2019 15:10:38 +0300
+Subject: iwlwifi: pcie: don't service an interrupt that was masked
+
+From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
+
+commit 3b57a10ca14c619707398dc58fe5ece18c95b20b upstream.
+
+Sometimes the register status can include interrupts that
+were masked. We can, for example, get the RF-Kill bit set
+in the interrupt status register although this interrupt
+was masked. Then if we get the ALIVE interrupt (for example)
+that was not masked, we need to *not* service the RF-Kill
+interrupt.
+Fix this in the MSI-X interrupt handler.
+
+Cc: stable@vger.kernel.org
+Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
+Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ drivers/net/wireless/intel/iwlwifi/pcie/rx.c |   27 +++++++++++++++++++++------
+ 1 file changed, 21 insertions(+), 6 deletions(-)
+
+--- a/drivers/net/wireless/intel/iwlwifi/pcie/rx.c
++++ b/drivers/net/wireless/intel/iwlwifi/pcie/rx.c
+@@ -2060,10 +2060,18 @@ irqreturn_t iwl_pcie_irq_msix_handler(in
+               return IRQ_NONE;
+       }
+-      if (iwl_have_debug_level(IWL_DL_ISR))
+-              IWL_DEBUG_ISR(trans, "ISR inta_fh 0x%08x, enabled 0x%08x\n",
+-                            inta_fh,
++      if (iwl_have_debug_level(IWL_DL_ISR)) {
++              IWL_DEBUG_ISR(trans,
++                            "ISR inta_fh 0x%08x, enabled (sw) 0x%08x (hw) 0x%08x\n",
++                            inta_fh, trans_pcie->fh_mask,
+                             iwl_read32(trans, CSR_MSIX_FH_INT_MASK_AD));
++              if (inta_fh & ~trans_pcie->fh_mask)
++                      IWL_DEBUG_ISR(trans,
++                                    "We got a masked interrupt (0x%08x)\n",
++                                    inta_fh & ~trans_pcie->fh_mask);
++      }
++
++      inta_fh &= trans_pcie->fh_mask;
+       if ((trans_pcie->shared_vec_mask & IWL_SHARED_IRQ_NON_RX) &&
+           inta_fh & MSIX_FH_INT_CAUSES_Q0) {
+@@ -2103,11 +2111,18 @@ irqreturn_t iwl_pcie_irq_msix_handler(in
+       }
+       /* After checking FH register check HW register */
+-      if (iwl_have_debug_level(IWL_DL_ISR))
++      if (iwl_have_debug_level(IWL_DL_ISR)) {
+               IWL_DEBUG_ISR(trans,
+-                            "ISR inta_hw 0x%08x, enabled 0x%08x\n",
+-                            inta_hw,
++                            "ISR inta_hw 0x%08x, enabled (sw) 0x%08x (hw) 0x%08x\n",
++                            inta_hw, trans_pcie->hw_mask,
+                             iwl_read32(trans, CSR_MSIX_HW_INT_MASK_AD));
++              if (inta_hw & ~trans_pcie->hw_mask)
++                      IWL_DEBUG_ISR(trans,
++                                    "We got a masked interrupt 0x%08x\n",
++                                    inta_hw & ~trans_pcie->hw_mask);
++      }
++
++      inta_hw &= trans_pcie->hw_mask;
+       /* Alive notification via Rx interrupt will do the real work */
+       if (inta_hw & MSIX_HW_INT_CAUSES_REG_ALIVE) {
diff --git a/queue-4.19/iwlwifi-pcie-fix-alive-interrupt-handling-for-gen2-devices-w-o-msi-x.patch b/queue-4.19/iwlwifi-pcie-fix-alive-interrupt-handling-for-gen2-devices-w-o-msi-x.patch
new file mode 100644 (file)
index 0000000..7a879d2
--- /dev/null
@@ -0,0 +1,72 @@
+From ec46ae30245ecb41d73f8254613db07c653fb498 Mon Sep 17 00:00:00 2001
+From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
+Date: Tue, 21 May 2019 15:03:21 +0300
+Subject: iwlwifi: pcie: fix ALIVE interrupt handling for gen2 devices w/o MSI-X
+
+From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
+
+commit ec46ae30245ecb41d73f8254613db07c653fb498 upstream.
+
+We added code to restock the buffer upon ALIVE interrupt
+when MSI-X is disabled. This was added as part of the context
+info code. This code was added only if the ISR debug level
+is set which is very unlikely to be related.
+Move this code to run even when the ISR debug level is not
+set.
+
+Note that gen2 devices work with MSI-X in most cases so that
+this path is seldom used.
+
+Cc: stable@vger.kernel.org
+Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
+Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ drivers/net/wireless/intel/iwlwifi/pcie/rx.c |   34 ++++++++++++---------------
+ 1 file changed, 16 insertions(+), 18 deletions(-)
+
+--- a/drivers/net/wireless/intel/iwlwifi/pcie/rx.c
++++ b/drivers/net/wireless/intel/iwlwifi/pcie/rx.c
+@@ -1778,25 +1778,23 @@ irqreturn_t iwl_pcie_irq_handler(int irq
+               goto out;
+       }
+-      if (iwl_have_debug_level(IWL_DL_ISR)) {
+-              /* NIC fires this, but we don't use it, redundant with WAKEUP */
+-              if (inta & CSR_INT_BIT_SCD) {
+-                      IWL_DEBUG_ISR(trans,
+-                                    "Scheduler finished to transmit the frame/frames.\n");
+-                      isr_stats->sch++;
+-              }
++      /* NIC fires this, but we don't use it, redundant with WAKEUP */
++      if (inta & CSR_INT_BIT_SCD) {
++              IWL_DEBUG_ISR(trans,
++                            "Scheduler finished to transmit the frame/frames.\n");
++              isr_stats->sch++;
++      }
+-              /* Alive notification via Rx interrupt will do the real work */
+-              if (inta & CSR_INT_BIT_ALIVE) {
+-                      IWL_DEBUG_ISR(trans, "Alive interrupt\n");
+-                      isr_stats->alive++;
+-                      if (trans->cfg->gen2) {
+-                              /*
+-                               * We can restock, since firmware configured
+-                               * the RFH
+-                               */
+-                              iwl_pcie_rxmq_restock(trans, trans_pcie->rxq);
+-                      }
++      /* Alive notification via Rx interrupt will do the real work */
++      if (inta & CSR_INT_BIT_ALIVE) {
++              IWL_DEBUG_ISR(trans, "Alive interrupt\n");
++              isr_stats->alive++;
++              if (trans->cfg->gen2) {
++                      /*
++                       * We can restock, since firmware configured
++                       * the RFH
++                       */
++                      iwl_pcie_rxmq_restock(trans, trans_pcie->rxq);
+               }
+       }
diff --git a/queue-4.19/regulator-s2mps11-fix-buck7-and-buck8-wrong-voltages.patch b/queue-4.19/regulator-s2mps11-fix-buck7-and-buck8-wrong-voltages.patch
new file mode 100644 (file)
index 0000000..925d7da
--- /dev/null
@@ -0,0 +1,42 @@
+From 16da0eb5ab6ef2dd1d33431199126e63db9997cc Mon Sep 17 00:00:00 2001
+From: Krzysztof Kozlowski <krzk@kernel.org>
+Date: Sat, 29 Jun 2019 13:44:45 +0200
+Subject: regulator: s2mps11: Fix buck7 and buck8 wrong voltages
+
+From: Krzysztof Kozlowski <krzk@kernel.org>
+
+commit 16da0eb5ab6ef2dd1d33431199126e63db9997cc upstream.
+
+On S2MPS11 device, the buck7 and buck8 regulator voltages start at 750
+mV, not 600 mV.  Using wrong minimal value caused shifting of these
+regulator values by 150 mV (e.g. buck7 usually configured to v1.35 V was
+reported as 1.2 V).
+
+On most of the boards these regulators are left in default state so this
+was only affecting reported voltage.  However if any driver wanted to
+change them, then effectively it would set voltage 150 mV higher than
+intended.
+
+Cc: <stable@vger.kernel.org>
+Fixes: cb74685ecb39 ("regulator: s2mps11: Add samsung s2mps11 regulator driver")
+Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
+Signed-off-by: Mark Brown <broonie@kernel.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ drivers/regulator/s2mps11.c |    4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+--- a/drivers/regulator/s2mps11.c
++++ b/drivers/regulator/s2mps11.c
+@@ -373,8 +373,8 @@ static const struct regulator_desc s2mps
+       regulator_desc_s2mps11_buck1_4(4),
+       regulator_desc_s2mps11_buck5,
+       regulator_desc_s2mps11_buck67810(6, MIN_600_MV, STEP_6_25_MV),
+-      regulator_desc_s2mps11_buck67810(7, MIN_600_MV, STEP_12_5_MV),
+-      regulator_desc_s2mps11_buck67810(8, MIN_600_MV, STEP_12_5_MV),
++      regulator_desc_s2mps11_buck67810(7, MIN_750_MV, STEP_12_5_MV),
++      regulator_desc_s2mps11_buck67810(8, MIN_750_MV, STEP_12_5_MV),
+       regulator_desc_s2mps11_buck9,
+       regulator_desc_s2mps11_buck67810(10, MIN_750_MV, STEP_12_5_MV),
+ };
diff --git a/queue-4.19/revert-bcache-set-cache_set_io_disable-in-bch_cached_dev_error.patch b/queue-4.19/revert-bcache-set-cache_set_io_disable-in-bch_cached_dev_error.patch
new file mode 100644 (file)
index 0000000..af16c42
--- /dev/null
@@ -0,0 +1,65 @@
+From 695277f16b3a102fcc22c97fdf2de77c7b19f0b3 Mon Sep 17 00:00:00 2001
+From: Coly Li <colyli@suse.de>
+Date: Fri, 28 Jun 2019 19:59:27 +0800
+Subject: Revert "bcache: set CACHE_SET_IO_DISABLE in bch_cached_dev_error()"
+
+From: Coly Li <colyli@suse.de>
+
+commit 695277f16b3a102fcc22c97fdf2de77c7b19f0b3 upstream.
+
+This reverts commit 6147305c73e4511ca1a975b766b97a779d442567.
+
+Although this patch helps the failed bcache device to stop faster when
+too many I/O errors detected on corresponding cached device, setting
+CACHE_SET_IO_DISABLE bit to cache set c->flags was not a good idea. This
+operation will disable all I/Os on cache set, which means other attached
+bcache devices won't work neither.
+
+Without this patch, the failed bcache device can also be stopped
+eventually if internal I/O accomplished (e.g. writeback). Therefore here
+I revert it.
+
+Fixes: 6147305c73e4 ("bcache: set CACHE_SET_IO_DISABLE in bch_cached_dev_error()")
+Reported-by: Yong Li <mr.liyong@qq.com>
+Signed-off-by: Coly Li <colyli@suse.de>
+Cc: stable@vger.kernel.org
+Signed-off-by: Jens Axboe <axboe@kernel.dk>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ drivers/md/bcache/super.c |   17 -----------------
+ 1 file changed, 17 deletions(-)
+
+--- a/drivers/md/bcache/super.c
++++ b/drivers/md/bcache/super.c
+@@ -1423,8 +1423,6 @@ int bch_flash_dev_create(struct cache_se
+ bool bch_cached_dev_error(struct cached_dev *dc)
+ {
+-      struct cache_set *c;
+-
+       if (!dc || test_bit(BCACHE_DEV_CLOSING, &dc->disk.flags))
+               return false;
+@@ -1435,21 +1433,6 @@ bool bch_cached_dev_error(struct cached_
+       pr_err("stop %s: too many IO errors on backing device %s\n",
+               dc->disk.disk->disk_name, dc->backing_dev_name);
+-      /*
+-       * If the cached device is still attached to a cache set,
+-       * even dc->io_disable is true and no more I/O requests
+-       * accepted, cache device internal I/O (writeback scan or
+-       * garbage collection) may still prevent bcache device from
+-       * being stopped. So here CACHE_SET_IO_DISABLE should be
+-       * set to c->flags too, to make the internal I/O to cache
+-       * device rejected and stopped immediately.
+-       * If c is NULL, that means the bcache device is not attached
+-       * to any cache set, then no CACHE_SET_IO_DISABLE bit to set.
+-       */
+-      c = dc->disk.c;
+-      if (c && test_and_set_bit(CACHE_SET_IO_DISABLE, &c->flags))
+-              pr_info("CACHE_SET_IO_DISABLE already set");
+-
+       bcache_device_stop(&dc->disk);
+       return true;
+ }
index 3a64f55254157285bd5c08ab1e0ed154c4c0f04a..e0e3feb0c8586d1200f934e149e398bf75baeec1 100644 (file)
@@ -180,3 +180,20 @@ crypto-crypto4xx-block-ciphers-should-only-accept-complete-blocks.patch
 crypto-ccp-memset-structure-fields-to-zero-before-reuse.patch
 crypto-ccp-gcm-use-const-time-tag-comparison.patch
 crypto-crypto4xx-fix-a-potential-double-free-in-ppc4xx_trng_probe.patch
+cifs-flush-before-set-info-if-we-have-writeable-handles.patch
+revert-bcache-set-cache_set_io_disable-in-bch_cached_dev_error.patch
+bcache-revert-bcache-fix-high-cpu-occupancy-during-journal.patch
+bcache-revert-bcache-free-heap-cache_set-flush_btree-in-bch_journal_free.patch
+bcache-ignore-read-ahead-request-failure-on-backing-device.patch
+bcache-fix-mistaken-sysfs-entry-for-io_error-counter.patch
+bcache-destroy-dc-writeback_write_wq-if-failed-to-create-dc-writeback_thread.patch
+input-gtco-bounds-check-collection-indent-level.patch
+input-alps-don-t-handle-alps-cs19-trackpoint-only-device.patch
+input-synaptics-whitelist-lenovo-t580-smbus-intertouch.patch
+input-alps-fix-a-mismatch-between-a-condition-check-and-its-comment.patch
+regulator-s2mps11-fix-buck7-and-buck8-wrong-voltages.patch
+arm64-tegra-update-jetson-tx1-gpu-regulator-timings.patch
+iwlwifi-pcie-don-t-service-an-interrupt-that-was-masked.patch
+iwlwifi-pcie-fix-alive-interrupt-handling-for-gen2-devices-w-o-msi-x.patch
+iwlwifi-don-t-warn-when-calling-iwl_get_shared_mem_conf-with-rf-kill.patch
+iwlwifi-fix-rf-kill-interrupt-while-fw-load-for-gen2-devices.patch