]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
Issue #17702: use assertRaises() for the unit test
authorVictor Stinner <victor.stinner@gmail.com>
Sun, 14 Apr 2013 14:43:03 +0000 (16:43 +0200)
committerVictor Stinner <victor.stinner@gmail.com>
Sun, 14 Apr 2013 14:43:03 +0000 (16:43 +0200)
Lib/test/test_os.py

index 83373be96e64fe34746673c3fd139c9ce38ae9fd..33b9e5b87e62872f0d5360f1d0ea9dbaa3ed38ae 100644 (file)
@@ -636,19 +636,13 @@ class EnvironTests(mapping_tests.BasicTestMappingProtocol):
         missing = 'missingkey'
         self.assertNotIn(missing, os.environ)
 
-        try:
+        with self.assertRaises(KeyError) as cm:
             os.environ[missing]
-        except KeyError as err:
-            self.assertIs(err.args[0], missing)
-        else:
-            self.fail("KeyError not raised")
+        self.assertIs(cm.exception.args[0], missing)
 
-        try:
+        with self.assertRaises(KeyError) as cm:
             del os.environ[missing]
-        except KeyError as err:
-            self.assertIs(err.args[0], missing)
-        else:
-            self.fail("KeyError not raised")
+        self.assertIs(cm.exception.args[0], missing)
 
 class WalkTests(unittest.TestCase):
     """Tests for os.walk()."""