wifi: iwlwifi: Fix incorrect logic on cmd_ver range checking

The current cmd_ver range checking on cmd_ver < 1 && cmd_ver > 3 can
never be true because the logical operator && is being used, cmd_ver
can never be less than 1 and also greater than 3. Fix this by using
the logical || operator.

Fixes: df6146a0296e ("wifi: iwlwifi: Add a new version for mac config command")
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Link: https://patch.msgid.link/20250522121703.2766764-1-colin.i.king@gmail.com
Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mld-mac.c b/drivers/net/wireless/intel/iwlwifi/mvm/mld-mac.c
index 81ca9ff67be96192b35f07fa01d6a4ec505a0a46..3c255ae916c85740a0e789e7e8a2662c3119e6b5 100644 (file)
--- a/drivers/net/wireless/intel/iwlwifi/mvm/mld-mac.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/mld-mac.c
@@ -34,7 +34,7 @@ static void iwl_mvm_mld_mac_ctxt_cmd_common(struct iwl_mvm *mvm,
                                            WIDE_ID(MAC_CONF_GROUP,
                                                    MAC_CONFIG_CMD), 0);
 
-       if (WARN_ON(cmd_ver < 1 && cmd_ver > 3))
+       if (WARN_ON(cmd_ver < 1 || cmd_ver > 3))
                return;
 
        cmd->id_and_color = cpu_to_le32(mvmvif->id);