lib-http: client: Fixed assert crash occurring when DNS lookup fails immediately...

In that situation, the request was not dropped from the queue immediately, triggering the assert crash.

diff --git a/src/lib-http/http-client-request.c b/src/lib-http/http-client-request.c
index f33a445a224f90f953848dcd01cbe107831bd383..e59bbecdf5291de4a291f607e700277399c6952a 100644 (file)
--- a/src/lib-http/http-client-request.c
+++ b/src/lib-http/http-client-request.c
@@ -900,6 +900,9 @@ void http_client_request_error(struct http_client_request *req,
        if (req->state >= HTTP_REQUEST_STATE_FINISHED)
                return;
 
+       if (req->queue != NULL)
+               http_client_queue_drop_request(req->queue, req);
+
        if (!req->submitted) {
                /* we're still in http_client_request_submit(). delay
                   reporting the error, so the caller doesn't have to handle
@@ -910,8 +913,6 @@ void http_client_request_error(struct http_client_request *req,
                http_client_host_delay_request_error(req->host, req);
        } else {
                http_client_request_send_error(req, status, error);
-               if (req->queue != NULL)
-                       http_client_queue_drop_request(req->queue, req);
                http_client_request_unref(&req);
        }
 }