]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
i2c: simplify with scoped for each OF child loop
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Fri, 16 Aug 2024 15:13:40 +0000 (17:13 +0200)
committerWolfram Sang <wsa+renesas@sang-engineering.com>
Tue, 3 Sep 2024 10:01:52 +0000 (12:01 +0200)
Use scoped for_each_child_of_node_scoped() when iterating over device
nodes to make code a bit simpler.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
drivers/i2c/i2c-core-slave.c

index e3765e12f93bf61c75c0f57ac60b4072daa1505f..faefe1dfa8e55b14d6179883937aa81cb72717b5 100644 (file)
@@ -109,15 +109,12 @@ EXPORT_SYMBOL_GPL(i2c_slave_event);
 bool i2c_detect_slave_mode(struct device *dev)
 {
        if (IS_BUILTIN(CONFIG_OF) && dev->of_node) {
-               struct device_node *child;
                u32 reg;
 
-               for_each_child_of_node(dev->of_node, child) {
+               for_each_child_of_node_scoped(dev->of_node, child) {
                        of_property_read_u32(child, "reg", &reg);
-                       if (reg & I2C_OWN_SLAVE_ADDRESS) {
-                               of_node_put(child);
+                       if (reg & I2C_OWN_SLAVE_ADDRESS)
                                return true;
-                       }
                }
        } else if (IS_BUILTIN(CONFIG_ACPI) && ACPI_HANDLE(dev)) {
                dev_dbg(dev, "ACPI slave is not supported yet\n");