Fix bug in vtable initialization

From-SVN: r177731

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 3aa3a5d7a386dd2b49ee9db4e61dbb87c176cc3e..b600d256a6eef9e82a4f4584b3a68d9b771095a0 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,8 @@
+2011-08-12  David Li  <davidxl@google.com>
+
+       * cp/class.c (update_vtable_entry_for_fn): Set
+       LOST_PRIMARY bit properly.
+
 2011-08-12  Richard Henderson  <rth@redhat.com>
 
        PR rtl-opt/49994

diff --git a/gcc/cp/class.c b/gcc/cp/class.c
index 26b7abe903dc81745dc4e63845f304de4bd08b02..fd0f011d0aedceea0fbf5401b61fd554e7ca93e9 100644 (file)
--- a/gcc/cp/class.c
+++ b/gcc/cp/class.c
@@ -2294,8 +2294,7 @@ update_vtable_entry_for_fn (tree t, tree binfo, tree fn, tree* virtuals,
   else
     BV_VCALL_INDEX (*virtuals) = NULL_TREE;
 
-  if (lost)
-    BV_LOST_PRIMARY (*virtuals) = true;
+  BV_LOST_PRIMARY (*virtuals) = lost;
 }
 
 /* Called from modify_all_vtables via dfs_walk.  */

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 4cede20faebf0ab83736c4acad5329176b3ccdf1..65097a3abdee496031671e71e66c2a5e0791f369 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2011-08-12  David Li  <davidxl@google.com>
+
+       * g++.dg/abi/vbase15.C: New test.
+
 2011-08-12  Jason Merrill  <jason@redhat.com>
 
        PR c++/50034

diff --git a/gcc/testsuite/g++.dg/abi/vbase15.C b/gcc/testsuite/g++.dg/abi/vbase15.C
new file mode 100644 (file)
index 0000000..a0908f4
--- /dev/null
+++ b/gcc/testsuite/g++.dg/abi/vbase15.C
@@ -0,0 +1,30 @@
+ // { dg-do run }
+
+struct Spec
+
+{
+ virtual int id () const = 0;
+};
+class D1_1_Spec :  public virtual Spec { };
+class D1_2_Spec :  public virtual Spec { };
+class D1_3_Spec :  public virtual Spec { };
+class D2_1_Spec : public D1_1_Spec, public D1_2_Spec { };
+class D2_Spec : public virtual D2_1_Spec, public virtual D1_3_Spec { };
+
+struct D3_Spec : public D2_Spec
+{
+ virtual int id () const { return 3; }
+
+};
+
+__attribute__((noinline)) void foo(D3_Spec* spec)
+{
+  spec->id();
+}
+
+int main()
+{
+ D3_Spec spec;
+ foo(&spec);
+ return 0;
+}