]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
arm64: dts: exynos: correct PMIC interrupt trigger level on Espresso
authorKrzysztof Kozlowski <krzk@kernel.org>
Thu, 10 Dec 2020 21:29:02 +0000 (22:29 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 3 Mar 2021 17:22:38 +0000 (18:22 +0100)
[ Upstream commit 1fea2eb2f5bbd3fbbe2513d2386b5f6e6db17fd7 ]

The Samsung PMIC datasheets describe the interrupt line as active low
with a requirement of acknowledge from the CPU.  Without specifying the
interrupt type in Devicetree, kernel might apply some fixed
configuration, not necessarily working for this hardware.

Fixes: 9589f7721e16 ("arm64: dts: Add S2MPS15 PMIC node on exynos7-espresso")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20201210212903.216728-8-krzk@kernel.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/arm64/boot/dts/exynos/exynos7-espresso.dts

index c8824b918693d081f14bbf1fc275485c1ca4ce5d..a85ad9f55cda05a45994b03b788ecb2c996efbbd 100644 (file)
@@ -88,7 +88,7 @@
        s2mps15_pmic@66 {
                compatible = "samsung,s2mps15-pmic";
                reg = <0x66>;
-               interrupts = <2 IRQ_TYPE_NONE>;
+               interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
                interrupt-parent = <&gpa0>;
                pinctrl-names = "default";
                pinctrl-0 = <&pmic_irq>;