]> git.ipfire.org Git - people/ms/suricata.git/commitdiff
detect: fix memory leak in app-layer-event keyword
authorVictor Julien <victor@inliniac.net>
Wed, 4 Jul 2018 13:10:34 +0000 (15:10 +0200)
committerVictor Julien <victor@inliniac.net>
Fri, 13 Jul 2018 07:10:28 +0000 (09:10 +0200)
Bug #2515.

src/detect-app-layer-event.c

index 1cb3dbd7fd8169467aed18ae434cd7877afa6df9..e77f7576bfd7c891f6c525aa3d643a21b96e5183 100644 (file)
@@ -285,6 +285,9 @@ static int DetectAppLayerEventSetupP2(Signature *s,
     if (DetectAppLayerEventParseAppP2((DetectAppLayerEventData *)sm->ctx, s->proto.proto,
                                       &event_type) < 0) {
         /* DetectAppLayerEventParseAppP2 prints errors */
+
+        /* sm has been removed from lists by DetectAppLayerEventPrepare */
+        SigMatchFree(sm);
         return -1;
     }
     SigMatchAppendSMToList(s, sm, g_applayer_events_list_id);