]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commitdiff
gdb/testsuite: Reduce indentation in gdb.threads/threadcrash.exp
authorTom de Vries <tdevries@suse.de>
Mon, 11 Mar 2024 09:57:31 +0000 (10:57 +0100)
committerTom de Vries <tdevries@suse.de>
Mon, 11 Mar 2024 09:57:31 +0000 (10:57 +0100)
In test-case gdb.threads/threadcrash.exp we have an unnecessarily indented
gdb_test_multiple:
...
    gdb_test_multiple "thread apply all backtrace" \
"Get thread information" -lbl {
    -re "#\[0-9\]+\\\?\\\?\[^\n\]*" {
...

Fix this by moving the command into a variable, allowing the
"gdb_test_multiple ... {" to fit on a single 80 chars line.

Tested on arm-linux and x86_64-linux.

gdb/testsuite/gdb.threads/threadcrash.exp

index 996e020d1e8de20fc9726f6b54614ac7b5267618..3d269ec88c51f976343035c745e0c85872e2a8fd 100644 (file)
@@ -53,64 +53,64 @@ proc thread_apply_all {} {
 
     set unwind_fail false
 
-    gdb_test_multiple "thread apply all backtrace" \
-       "Get thread information" -lbl {
-           -re "#\[0-9\]+\\\?\\\?\[^\n\]*" {
-               set unwind_fail true
-               exp_continue
-           }
-           -re "\[^\n\]*syscall_task .location=SIGNAL_ALT_STACK\[^\n\]*" {
-               lappend test_list [multi_line ".*sleep.*" \
-                                             ".*do_syscall_task .location=SIGNAL_ALT_STACK.*" \
-                                             ".*signal_handler.*" \
-                                             ".*signal handler called.*" \
-                                             ".*pthread_kill.*" \
-                                             ".*thread_function.*"]
-               exp_continue
-           }
-           -re "\[^\n\]*syscall_task .location=SIGNAL_HANDLER\[^\n\]*" {
-               lappend test_list [multi_line ".*sleep.*" \
-                                             ".*do_syscall_task .location=SIGNAL_HANDLER.*" \
-                                             ".*signal_handler.*" \
-                                             ".*signal handler called.*" \
-                                             ".*pthread_kill.*" \
-                                             ".*thread_function.*"]
-               exp_continue
-           }
-           -re "\[^\n\]*syscall_task .location=NORMAL\[^\n\]*" {
-               lappend test_list [multi_line ".*sleep.*" \
-                                             ".*do_syscall_task .location=NORMAL.*" \
-                                             ".*thread_function.*"]
-               exp_continue
-           }
-           -re "\[^\n\]*spin_task .location=SIGNAL_ALT_STACK\[^\n\]*" {
-               lappend test_list [multi_line ".*do_spin_task .location=SIGNAL_ALT_STACK.*" \
-                                             ".*signal_handler.*" \
-                                             ".*signal handler called.*" \
-                                             ".*pthread_kill.*" \
-                                             ".*thread_function.*"]
-               exp_continue
-           }
-           -re "\[^\n\]*spin_task .location=SIGNAL_HANDLER\[^\n\]*" {
-               lappend test_list [multi_line ".*do_spin_task .location=SIGNAL_HANDLER.*" \
-                                             ".*signal_handler.*" \
-                                             ".*signal handler called.*" \
-                                             ".*pthread_kill.*" \
-                                             ".*thread_function.*"]
-               exp_continue
-           }
-           -re "\[^\n\]*spin_task .location=NORMAL\[^\n\]*" {
-               lappend test_list [multi_line ".*do_spin_task .location=NORMAL..*" \
-                                             ".*thread_function.*"]
-               exp_continue
-           }
-           -re "\[^\n\]*main\[^\n\]*" {
-               lappend test_list ".*main.*"
-               exp_continue
-           }
-           -re "$::gdb_prompt " {
-               pass $gdb_test_name
-           }
+    set cmd "thread apply all backtrace"
+    gdb_test_multiple $cmd "Get thread information" -lbl {
+       -re "#\[0-9\]+\\\?\\\?\[^\n\]*" {
+           set unwind_fail true
+           exp_continue
+       }
+       -re "\[^\n\]*syscall_task .location=SIGNAL_ALT_STACK\[^\n\]*" {
+           lappend test_list [multi_line ".*sleep.*" \
+                                  ".*do_syscall_task .location=SIGNAL_ALT_STACK.*" \
+                                  ".*signal_handler.*" \
+                                  ".*signal handler called.*" \
+                                  ".*pthread_kill.*" \
+                                  ".*thread_function.*"]
+           exp_continue
+       }
+       -re "\[^\n\]*syscall_task .location=SIGNAL_HANDLER\[^\n\]*" {
+           lappend test_list [multi_line ".*sleep.*" \
+                                  ".*do_syscall_task .location=SIGNAL_HANDLER.*" \
+                                  ".*signal_handler.*" \
+                                  ".*signal handler called.*" \
+                                  ".*pthread_kill.*" \
+                                  ".*thread_function.*"]
+           exp_continue
+       }
+       -re "\[^\n\]*syscall_task .location=NORMAL\[^\n\]*" {
+           lappend test_list [multi_line ".*sleep.*" \
+                                  ".*do_syscall_task .location=NORMAL.*" \
+                                  ".*thread_function.*"]
+           exp_continue
+       }
+       -re "\[^\n\]*spin_task .location=SIGNAL_ALT_STACK\[^\n\]*" {
+           lappend test_list [multi_line ".*do_spin_task .location=SIGNAL_ALT_STACK.*" \
+                                  ".*signal_handler.*" \
+                                  ".*signal handler called.*" \
+                                  ".*pthread_kill.*" \
+                                  ".*thread_function.*"]
+           exp_continue
+       }
+       -re "\[^\n\]*spin_task .location=SIGNAL_HANDLER\[^\n\]*" {
+           lappend test_list [multi_line ".*do_spin_task .location=SIGNAL_HANDLER.*" \
+                                  ".*signal_handler.*" \
+                                  ".*signal handler called.*" \
+                                  ".*pthread_kill.*" \
+                                  ".*thread_function.*"]
+           exp_continue
+       }
+       -re "\[^\n\]*spin_task .location=NORMAL\[^\n\]*" {
+           lappend test_list [multi_line ".*do_spin_task .location=NORMAL..*" \
+                                  ".*thread_function.*"]
+           exp_continue
+       }
+       -re "\[^\n\]*main\[^\n\]*" {
+           lappend test_list ".*main.*"
+           exp_continue
+       }
+       -re "$::gdb_prompt " {
+           pass $gdb_test_name
+       }
     }
 
     gdb_assert {$unwind_fail == false}