parser_bison: fix memleak in meta set error handling

commit 21608263cc1ae489326e743957bfe34b05414a44 upstream.

We must release the expression here, found via afl++ and
-fsanitize-address build.

Signed-off-by: Florian Westphal <fw@strlen.de>

diff --git a/src/parser_bison.y b/src/parser_bison.y
index 0922ccf1ccdbd405ce1bc6486bf240f9d918c06c..8f5ab29a5f7499518323fa2e07bc96bcd8e6711b 100644 (file)
--- a/src/parser_bison.y
+++ b/src/parser_bison.y
@@ -5142,6 +5142,7 @@ meta_stmt         :       META    meta_key        SET     stmt_expr       close_scope_meta
                                xfree($2);
                                if (erec != NULL) {
                                        erec_queue(erec, state->msgs);
+                                       expr_free($4);
                                        YYERROR;
                                }
 

diff --git a/tests/shell/testcases/bogons/nft-f/memleak_on_meta_set_errpath b/tests/shell/testcases/bogons/nft-f/memleak_on_meta_set_errpath
new file mode 100644 (file)
index 0000000..917e8bf
--- /dev/null
+++ b/tests/shell/testcases/bogons/nft-f/memleak_on_meta_set_errpath
@@ -0,0 +1,5 @@
+table filter {
+ chain y {
+  meta seccark set ct secmark
+ }
+}