]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
RDMA/siw: replace redundant ternary operator with just rv
authorColin Ian King <colin.i.king@gmail.com>
Wed, 7 May 2025 13:18:34 +0000 (14:18 +0100)
committerLeon Romanovsky <leon@kernel.org>
Mon, 12 May 2025 10:20:24 +0000 (06:20 -0400)
The use of the ternary operator on rv is redundant, rv is
either the initialized value of 0 or a negative error return
code, so it can never be greater than zero, and hence the
zero assignment in ternary operator is redundant. Just return
rv instead.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Link: https://patch.msgid.link/20250507131834.253823-1-colin.i.king@gmail.com
Acked-by: Bernard Metzler <bmt@zurich.ibm.com>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
drivers/infiniband/sw/siw/siw_verbs.c

index 7ce0035c54fac123397df811af0618c0d55fa1e8..2b2a7b8e93b017e6d5b600f0c2705f3fb1e6c5a7 100644 (file)
@@ -1102,7 +1102,7 @@ int siw_post_receive(struct ib_qp *base_qp, const struct ib_recv_wr *wr,
                siw_dbg_qp(qp, "error %d\n", rv);
                *bad_wr = wr;
        }
-       return rv > 0 ? 0 : rv;
+       return rv;
 }
 
 int siw_destroy_cq(struct ib_cq *base_cq, struct ib_udata *udata)