]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: ngbevf: add sw init pci info and reset hardware
authorMengyuan Lou <mengyuanlou@net-swift.com>
Fri, 4 Jul 2025 09:49:21 +0000 (17:49 +0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 10 Jul 2025 01:39:14 +0000 (18:39 -0700)
Do sw init and reset hw for ngbevf virtual functions, then
register netdev.

Signed-off-by: Mengyuan Lou <mengyuanlou@net-swift.com>
Link: https://patch.msgid.link/20250704094923.652-11-mengyuanlou@net-swift.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/wangxun/ngbevf/ngbevf_main.c
drivers/net/ethernet/wangxun/ngbevf/ngbevf_type.h

index 77025e7deeeb2f93b182958fb1fc83952b50daf0..4eea682f024b92171040fd7eef380eee4ee0a7e8 100644 (file)
@@ -9,6 +9,9 @@
 #include <linux/etherdevice.h>
 
 #include "../libwx/wx_type.h"
+#include "../libwx/wx_hw.h"
+#include "../libwx/wx_mbx.h"
+#include "../libwx/wx_vf.h"
 #include "../libwx/wx_vf_common.h"
 #include "ngbevf_type.h"
 
@@ -37,6 +40,75 @@ static const struct pci_device_id ngbevf_pci_tbl[] = {
        { .device = 0 }
 };
 
+static const struct net_device_ops ngbevf_netdev_ops = {
+       .ndo_open               = wxvf_open,
+       .ndo_stop               = wxvf_close,
+       .ndo_validate_addr      = eth_validate_addr,
+       .ndo_set_mac_address    = wx_set_mac_vf,
+};
+
+static int ngbevf_sw_init(struct wx *wx)
+{
+       struct net_device *netdev = wx->netdev;
+       struct pci_dev *pdev = wx->pdev;
+       int err;
+
+       /* Initialize pcie info and common capability flags */
+       err = wx_sw_init(wx);
+       if (err < 0)
+               goto err_wx_sw_init;
+
+       /* Initialize the mailbox */
+       err = wx_init_mbx_params_vf(wx);
+       if (err)
+               goto err_init_mbx_params;
+
+       /* Initialize the device type */
+       wx->mac.type = wx_mac_em;
+       /* lock to protect mailbox accesses */
+       spin_lock_init(&wx->mbx.mbx_lock);
+
+       err = wx_reset_hw_vf(wx);
+       if (err) {
+               wx_err(wx, "PF still in reset state. Is the PF interface up?\n");
+               goto err_reset_hw;
+       }
+       wx_init_hw_vf(wx);
+       wx_negotiate_api_vf(wx);
+       if (is_zero_ether_addr(wx->mac.addr))
+               dev_info(&pdev->dev,
+                        "MAC address not assigned by administrator.\n");
+       eth_hw_addr_set(netdev, wx->mac.addr);
+
+       if (!is_valid_ether_addr(netdev->dev_addr)) {
+               dev_info(&pdev->dev, "Assigning random MAC address\n");
+               eth_hw_addr_random(netdev);
+               ether_addr_copy(wx->mac.addr, netdev->dev_addr);
+               ether_addr_copy(wx->mac.perm_addr, netdev->dev_addr);
+       }
+
+       wx->mac.max_tx_queues = NGBEVF_MAX_TX_QUEUES;
+       wx->mac.max_rx_queues = NGBEVF_MAX_RX_QUEUES;
+       /* Enable dynamic interrupt throttling rates */
+       wx->rx_itr_setting = 1;
+       wx->tx_itr_setting = 1;
+       /* set default ring sizes */
+       wx->tx_ring_count = NGBEVF_DEFAULT_TXD;
+       wx->rx_ring_count = NGBEVF_DEFAULT_RXD;
+       /* set default work limits */
+       wx->tx_work_limit = NGBEVF_DEFAULT_TX_WORK;
+       wx->rx_work_limit = NGBEVF_DEFAULT_RX_WORK;
+
+       return 0;
+err_reset_hw:
+       kfree(wx->vfinfo);
+err_init_mbx_params:
+       kfree(wx->rss_key);
+       kfree(wx->mac_table);
+err_wx_sw_init:
+       return err;
+}
+
 /**
  * ngbevf_probe - Device Initialization Routine
  * @pdev: PCI device information struct
@@ -102,11 +174,30 @@ static int ngbevf_probe(struct pci_dev *pdev,
                goto err_pci_release_regions;
        }
 
+       netdev->netdev_ops = &ngbevf_netdev_ops;
+
+       /* setup the private structure */
+       err = ngbevf_sw_init(wx);
+       if (err)
+               goto err_pci_release_regions;
+
        netdev->features |= NETIF_F_HIGHDMA;
+
+       eth_hw_addr_set(netdev, wx->mac.perm_addr);
+       ether_addr_copy(netdev->perm_addr, wx->mac.addr);
+
+       err = register_netdev(netdev);
+       if (err)
+               goto err_register;
+
        pci_set_drvdata(pdev, wx);
 
        return 0;
 
+err_register:
+       kfree(wx->vfinfo);
+       kfree(wx->rss_key);
+       kfree(wx->mac_table);
 err_pci_release_regions:
        pci_release_selected_regions(pdev,
                                     pci_select_bars(pdev, IORESOURCE_MEM));
index c71a244ec6b9577bfddffdc4c806a915e34b0d80..dc29349304f1f56faad4b4a42805e731d90d1f32 100644 (file)
@@ -20,5 +20,9 @@
 
 #define NGBEVF_MAX_RX_QUEUES                  1
 #define NGBEVF_MAX_TX_QUEUES                  1
+#define NGBEVF_DEFAULT_TXD                    128
+#define NGBEVF_DEFAULT_RXD                    128
+#define NGBEVF_DEFAULT_TX_WORK                256
+#define NGBEVF_DEFAULT_RX_WORK                256
 
 #endif /* _NGBEVF_TYPE_H_ */