]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
nmbd: Fixing CID 1509039 for time_t in DEBUG statement
authorRabinarayan Panigrahi <rapanigr@redhat.com>
Fri, 5 Sep 2025 05:01:16 +0000 (10:31 +0530)
committerAndreas Schneider <asn@cryptomilk.org>
Wed, 10 Sep 2025 09:38:30 +0000 (09:38 +0000)
Fix: typecast changing from (int)t to (intmax_t)t as intmax_t
can hold epoch seconds after 2038 year

Signed-off-by: Rabinarayan Panigrahi <rapanigr@redhat.com>
Reviewed-by: Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Andreas Schneider <asn@samba.org>
source3/libads/sitename_cache.c
source3/nmbd/nmbd_sendannounce.c

index 4bf2ca7ae2e98044f9fd3b85b8207608c7f5de7d..88976baefb7f05856bc56f64ad1c8c97ae6af6c2 100644 (file)
@@ -63,8 +63,8 @@ bool sitename_store(const char *realm, const char *sitename)
 
        expire = get_time_t_max(); /* Store indefinitely. */
 
-       DEBUG(10,("sitename_store: realm = [%s], sitename = [%s], expire = [%u]\n",
-               realm, sitename, (unsigned int)expire ));
+       DEBUG(10,("sitename_store: realm = [%s], sitename = [%s], expire = [%jd]\n",
+               realm, sitename, (intmax_t)expire ));
 
        ret = gencache_set( key, sitename, expire );
        TALLOC_FREE(key);
index 4e8be04f3b58b0e655b4f38c9734be7c13a475a8..e9b87040c43e67ae1f505365575df8363564e9dc 100644 (file)
@@ -384,8 +384,8 @@ void announce_myself_to_domain_master_browser(time_t t)
                announce_timer_last = t;
 
        if ((t-announce_timer_last) < (CHECK_TIME_MST_ANNOUNCE * 60)) {
-               DBG_DEBUG("announce_myself_to_domain_master_browser: t (%d) - last(%d) < %d\n",
-                       (int)t, (int)announce_timer_last, 
+               DBG_DEBUG("announce_myself_to_domain_master_browser: t (%jd) - last(%d) < %d\n",
+                       (intmax_t)t, (int)announce_timer_last,
                        CHECK_TIME_MST_ANNOUNCE * 60 );
                return;
        }