]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
KVM: Allow calling kvm_release_page_{clean,dirty}() on a NULL page pointer
authorSean Christopherson <seanjc@google.com>
Thu, 10 Oct 2024 18:23:04 +0000 (11:23 -0700)
committerPaolo Bonzini <pbonzini@redhat.com>
Fri, 25 Oct 2024 16:54:42 +0000 (12:54 -0400)
Allow passing a NULL @page to kvm_release_page_{clean,dirty}(), there's no
tangible benefit to forcing the callers to pre-check @page, and it ends up
generating a lot of duplicate boilerplate code.

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Tested-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Sean Christopherson <seanjc@google.com>
Tested-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <20241010182427.1434605-3-seanjc@google.com>

virt/kvm/kvm_main.c

index 5fc95504affeaaa1ab77cb3a484f09f799f4e0ef..e7561ca96a095a64a99634c10708803dad0c94b8 100644 (file)
@@ -3167,7 +3167,7 @@ static void kvm_set_page_accessed(struct page *page)
 
 void kvm_release_page_clean(struct page *page)
 {
-       if (WARN_ON(!page))
+       if (!page)
                return;
 
        kvm_set_page_accessed(page);
@@ -3192,7 +3192,7 @@ EXPORT_SYMBOL_GPL(kvm_release_pfn_clean);
 
 void kvm_release_page_dirty(struct page *page)
 {
-       if (WARN_ON(!page))
+       if (!page)
                return;
 
        kvm_set_page_dirty(page);