]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
wifi: ath12k: ath12k_mac_station_add(): fix potential rx_stats leak
authorRameshkumar Sundaram <quic_ramess@quicinc.com>
Tue, 26 Nov 2024 17:11:34 +0000 (19:11 +0200)
committerKalle Valo <quic_kvalo@quicinc.com>
Fri, 29 Nov 2024 11:17:45 +0000 (13:17 +0200)
If peer creation fails ar->rx_stats needs to be freed in error handling.

Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1
Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3

Signed-off-by: Rameshkumar Sundaram <quic_ramess@quicinc.com>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://patch.msgid.link/20241126171139.2350704-6-kvalo@kernel.org
drivers/net/wireless/ath/ath12k/mac.c

index ec8209f172613b98a36885be2ee7cd36ecef63a9..0b9dd50959e6b0e25d5767b8cd042a601ce37136 100644 (file)
@@ -5308,6 +5308,8 @@ static int ath12k_mac_station_add(struct ath12k *ar,
 
 free_peer:
        ath12k_peer_delete(ar, arvif->vdev_id, arsta->addr);
+       kfree(arsta->rx_stats);
+       arsta->rx_stats = NULL;
 dec_num_station:
        ath12k_mac_dec_num_stations(arvif, arsta);
 exit: