]> git.ipfire.org Git - thirdparty/haproxy.git/commitdiff
CLEANUP: promex: remove unused PROMEX_FL_{INFO,FRONT,BACK,LI,SRV} flags
authorAurelien DARRAGON <adarragon@haproxy.com>
Thu, 20 Mar 2025 10:24:23 +0000 (11:24 +0100)
committerAurelien DARRAGON <adarragon@haproxy.com>
Thu, 20 Mar 2025 10:42:58 +0000 (11:42 +0100)
Now promex metric dumping relies on stat_cols API, we don't make use of
these flags, so let's remove them.

addons/promex/include/promex/promex.h
addons/promex/service-prometheus.c

index 517c472bbab3e9d21bde9b2fed8c367f04d875dd..7b838da153fb4b22db5cb7f297a41a2fe8977df1 100644 (file)
 
 /* Prometheus exporter flags (ctx->flags) */
 #define PROMEX_FL_METRIC_HDR        0x00000001
-#define PROMEX_FL_INFO_METRIC       0x00000002
-#define PROMEX_FL_FRONT_METRIC      0x00000004
-#define PROMEX_FL_BACK_METRIC       0x00000008
-#define PROMEX_FL_SRV_METRIC        0x00000010
-#define PROMEX_FL_LI_METRIC         0x00000020
+/* unused: 0x00000002 */
+/* unused: 0x00000004 */
+/* unused: 0x00000008 */
+/* unused: 0x00000010 */
+/* unused: 0x00000020 */
 #define PROMEX_FL_MODULE_METRIC     0x00000040
 #define PROMEX_FL_SCOPE_GLOBAL      0x00000080
 #define PROMEX_FL_SCOPE_FRONT       0x00000100
index a06bf1e36642b472554a9f00fa853cb518133df7..56edb264b968bbc0f145e6283c4e61226f4d1e50 100644 (file)
@@ -1805,7 +1805,7 @@ static int promex_dump_metrics(struct appctx *appctx, struct stconn *sc, struct
 
        switch (appctx->st1) {
                case PROMEX_DUMPER_INIT:
-                       ctx->flags |= (PROMEX_FL_METRIC_HDR|PROMEX_FL_INFO_METRIC);
+                       ctx->flags |= PROMEX_FL_METRIC_HDR;
                        ctx->obj_state = 0;
                        ctx->field_num = ST_I_INF_NAME;
                        appctx->st1 = PROMEX_DUMPER_GLOBAL;
@@ -1821,8 +1821,7 @@ static int promex_dump_metrics(struct appctx *appctx, struct stconn *sc, struct
                                }
                        }
 
-                       ctx->flags &= ~PROMEX_FL_INFO_METRIC;
-                       ctx->flags |= (PROMEX_FL_METRIC_HDR|PROMEX_FL_FRONT_METRIC);
+                       ctx->flags |= PROMEX_FL_METRIC_HDR;
                        ctx->obj_state = 0;
                        ctx->field_num = ST_I_PX_PXNAME;
                        ctx->mod_field_num = 0;
@@ -1839,8 +1838,7 @@ static int promex_dump_metrics(struct appctx *appctx, struct stconn *sc, struct
                                }
                        }
 
-                       ctx->flags &= ~PROMEX_FL_FRONT_METRIC;
-                       ctx->flags |= (PROMEX_FL_METRIC_HDR|PROMEX_FL_LI_METRIC);
+                       ctx->flags |= PROMEX_FL_METRIC_HDR;
                        ctx->obj_state = 0;
                        ctx->field_num = ST_I_PX_PXNAME;
                        ctx->mod_field_num = 0;
@@ -1857,8 +1855,7 @@ static int promex_dump_metrics(struct appctx *appctx, struct stconn *sc, struct
                                }
                        }
 
-                       ctx->flags &= ~PROMEX_FL_LI_METRIC;
-                       ctx->flags |= (PROMEX_FL_METRIC_HDR|PROMEX_FL_BACK_METRIC);
+                       ctx->flags |= PROMEX_FL_METRIC_HDR;
                        ctx->obj_state = 0;
                        ctx->field_num = ST_I_PX_PXNAME;
                        ctx->mod_field_num = 0;
@@ -1875,8 +1872,7 @@ static int promex_dump_metrics(struct appctx *appctx, struct stconn *sc, struct
                                }
                        }
 
-                       ctx->flags &= ~PROMEX_FL_BACK_METRIC;
-                       ctx->flags |= (PROMEX_FL_METRIC_HDR|PROMEX_FL_SRV_METRIC);
+                       ctx->flags |= PROMEX_FL_METRIC_HDR;
                        ctx->obj_state = 0;
                        ctx->field_num = ST_I_PX_PXNAME;
                        ctx->mod_field_num = 0;
@@ -1893,7 +1889,6 @@ static int promex_dump_metrics(struct appctx *appctx, struct stconn *sc, struct
                                }
                        }
 
-                       ctx->flags &= ~(PROMEX_FL_METRIC_HDR|PROMEX_FL_SRV_METRIC);
                        ctx->flags |= (PROMEX_FL_METRIC_HDR|PROMEX_FL_MODULE_METRIC);
                        ctx->field_num = 0;
                        ctx->mod_field_num = 0;