Fix build issue with Python 3.7

Originally reported in
https://bugzilla.redhat.com/show_bug.cgi?id=1577396 -- gdb build fails
with Python 3.7 due to references to a Python internal function whose
declaration changed in 3.7.

gdb/ChangeLog
2018-06-09  Paul Koning  <paul_koning@dell.com>

	    PR gdb/23252

	    * python/python.c (do_start_initialization):
	    Avoid call to internal Python API.
	    (init__gdb_module): New function.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 7986a62d07bb75ba6ad0f9b11aa3446a3fa2ed05..860062cae00ae2314f904970d35651348e3a8402 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,11 @@
+2018-06-09  Paul Koning  <paul_koning@dell.com>
+
+       PR gdb/23252
+
+       * python/python.c (do_start_initialization):
+       Avoid call to internal Python API.
+       (init__gdb_module): New function.
+
 2018-05-31  Omair Javaid  <omair.javaid@linaro.org>
 
        PR gdb/23210

diff --git a/gdb/python/python.c b/gdb/python/python.c
index 4844c86c5433687cadf07ed091150b1855120e07..bb0a46d8580a14072cee0a18e2e1a251096f352c 100644 (file)
--- a/gdb/python/python.c
+++ b/gdb/python/python.c
@@ -1656,6 +1656,17 @@ finalize_python (void *ignore)
   restore_active_ext_lang (previous_active);
 }
 
+#ifdef IS_PY3K
+/* This is called via the PyImport_AppendInittab mechanism called
+   during initialization, to make the built-in _gdb module known to
+   Python.  */
+PyMODINIT_FUNC
+init__gdb_module (void)
+{
+  return PyModule_Create (&python_GdbModuleDef);
+}
+#endif
+
 static bool
 do_start_initialization ()
 {
@@ -1696,6 +1707,9 @@ do_start_initialization ()
      remain alive for the duration of the program's execution, so
      it is not freed after this call.  */
   Py_SetProgramName (progname_copy);
+
+  /* Define _gdb as a built-in module.  */
+  PyImport_AppendInittab ("_gdb", init__gdb_module);
 #else
   Py_SetProgramName (progname.release ());
 #endif
@@ -1705,9 +1719,7 @@ do_start_initialization ()
   PyEval_InitThreads ();
 
 #ifdef IS_PY3K
-  gdb_module = PyModule_Create (&python_GdbModuleDef);
-  /* Add _gdb module to the list of known built-in modules.  */
-  _PyImport_FixupBuiltin (gdb_module, "_gdb");
+  gdb_module = PyImport_ImportModule ("_gdb");
 #else
   gdb_module = Py_InitModule ("_gdb", python_GdbMethods);
 #endif