scsi: lpfc: Remove extra ndlp kref decrement in FLOGI cmpl for loop topology

In lpfc_cmpl_els_flogi(), the return out: label decrements the ndlp kref
signaling that FLOGI processing on the ndlp is complete.  In loop topology
path, there is an unnecessary ndlp put because it also branches to the out:
label.  This also signals ndlp usage completion too soon.  As such, remove
the extra lpfc_nlp_put() when in loop topology.

Signed-off-by: Justin Tee <justin.tee@broadcom.com>
Link: https://lore.kernel.org/r/20230712180522.112722-4-justintee8345@gmail.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
index 2bad9954c355f66ce0c78b3447c42072a8b1f604..9a7b62d18455234550fdd17663b6c702290b630a 100644 (file)
--- a/drivers/scsi/lpfc/lpfc_els.c
+++ b/drivers/scsi/lpfc/lpfc_els.c
@@ -1041,7 +1041,7 @@ stop_rr_fcf_flogi:
                    !(ndlp->fc4_xpt_flags & SCSI_XPT_REGD))
                        lpfc_nlp_put(ndlp);
 
-               lpfc_printf_vlog(vport, KERN_WARNING, LOG_TRACE_EVENT,
+               lpfc_printf_vlog(vport, KERN_WARNING, LOG_ELS,
                                 "0150 FLOGI failure Status:x%x/x%x "
                                 "xri x%x TMO:x%x refcnt %d\n",
                                 ulp_status, ulp_word4, cmdiocb->sli4_xritag,
@@ -1091,7 +1091,6 @@ stop_rr_fcf_flogi:
                        if (!lpfc_error_lost_link(vport, ulp_status, ulp_word4))
                                lpfc_issue_reg_vfi(vport);
 
-                       lpfc_nlp_put(ndlp);
                        goto out;
                }
                goto flogifail;