]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
5.15-stable patches
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 20 Dec 2021 13:16:38 +0000 (14:16 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 20 Dec 2021 13:16:38 +0000 (14:16 +0100)
added patches:
revert-xsk-do-not-sleep-in-poll-when-need_wakeup-set.patch

queue-5.15/revert-xsk-do-not-sleep-in-poll-when-need_wakeup-set.patch [new file with mode: 0644]
queue-5.15/series

diff --git a/queue-5.15/revert-xsk-do-not-sleep-in-poll-when-need_wakeup-set.patch b/queue-5.15/revert-xsk-do-not-sleep-in-poll-when-need_wakeup-set.patch
new file mode 100644 (file)
index 0000000..2f7fd67
--- /dev/null
@@ -0,0 +1,46 @@
+From 0706a78f31c4217ca144f630063ec9561a21548d Mon Sep 17 00:00:00 2001
+From: Magnus Karlsson <magnus.karlsson@intel.com>
+Date: Fri, 17 Dec 2021 15:56:46 +0100
+Subject: Revert "xsk: Do not sleep in poll() when need_wakeup set"
+
+From: Magnus Karlsson <magnus.karlsson@intel.com>
+
+commit 0706a78f31c4217ca144f630063ec9561a21548d upstream.
+
+This reverts commit bd0687c18e635b63233dc87f38058cd728802ab4.
+
+This patch causes a Tx only workload to go to sleep even when it does
+not have to, leading to misserable performance in skb mode. It fixed
+one rare problem but created a much worse one, so this need to be
+reverted while I try to craft a proper solution to the original
+problem.
+
+Fixes: bd0687c18e63 ("xsk: Do not sleep in poll() when need_wakeup set")
+Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com>
+Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
+Link: https://lore.kernel.org/bpf/20211217145646.26449-1-magnus.karlsson@gmail.com
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ net/xdp/xsk.c |    4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+--- a/net/xdp/xsk.c
++++ b/net/xdp/xsk.c
+@@ -692,6 +692,8 @@ static __poll_t xsk_poll(struct file *fi
+       struct xdp_sock *xs = xdp_sk(sk);
+       struct xsk_buff_pool *pool;
++      sock_poll_wait(file, sock, wait);
++
+       if (unlikely(!xsk_is_bound(xs)))
+               return mask;
+@@ -703,8 +705,6 @@ static __poll_t xsk_poll(struct file *fi
+               else
+                       /* Poll needs to drive Tx also in copy mode */
+                       __xsk_sendmsg(sk);
+-      } else {
+-              sock_poll_wait(file, sock, wait);
+       }
+       if (xs->rx && !xskq_prod_is_empty(xs->rx))
index 33b6806c177cf2aca8f52c29f85f66e00f4fbbba..971e1cda02d6caa667c61a5039a192e92cdce689 100644 (file)
@@ -169,3 +169,4 @@ rcu-mark-accesses-to-rcu_state.n_force_qs.patch
 io-wq-drop-wqe-lock-before-creating-new-worker.patch
 bus-ti-sysc-fix-variable-set-but-not-used-warning-for-reinit_modules.patch
 selftests-damon-test-debugfs-file-reads-writes-with-huge-count.patch
+revert-xsk-do-not-sleep-in-poll-when-need_wakeup-set.patch