]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
PM / wakeup: only recommend "call"ing device_init_wakeup() once
authorBrian Norris <briannorris@chromium.org>
Mon, 18 Dec 2017 23:30:48 +0000 (15:30 -0800)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 19 Dec 2017 01:45:06 +0000 (02:45 +0100)
I'll admit admit it: I've written bad driver code that tries to
configure a device's wake IRQ without having called device_init_wakeup()
first. But do you really have to ask ask me twice?

Signed-off-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/base/power/wakeup.c

index 38559f04db2cfdf2ad9d71b562ce6825317aa8e1..cb72965b3281238ee3ab4cde8447501a4e9952bf 100644 (file)
@@ -298,7 +298,7 @@ int device_wakeup_attach_irq(struct device *dev,
 
        ws = dev->power.wakeup;
        if (!ws) {
-               dev_err(dev, "forgot to call call device_init_wakeup?\n");
+               dev_err(dev, "forgot to call device_init_wakeup?\n");
                return -EINVAL;
        }