]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
sh_eth: Remove dummy Runtime PM callbacks
authorGeert Uytterhoeven <geert+renesas@glider.be>
Thu, 4 Sep 2025 15:18:56 +0000 (17:18 +0200)
committerJakub Kicinski <kuba@kernel.org>
Sat, 6 Sep 2025 01:16:07 +0000 (18:16 -0700)
Since commit 63d00be69348fda4 ("PM: runtime: Allow unassigned
->runtime_suspend|resume callbacks"), unassigned
.runtime_{suspend,resume}() callbacks are treated the same as dummy
callbacks that just return zero.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Tested-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Link: https://patch.msgid.link/ab2a8bb51eb7d02426f4072c27523c8f41ac1ad4.1756998732.git.geert+renesas@glider.be
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/renesas/sh_eth.c

index 5fc8027c92c7c95bd4e2bd586b996fe1ec1010b7..0516db9dc946fcdb3ef7826fd650d330d9cb53fc 100644 (file)
@@ -3529,21 +3529,8 @@ static int sh_eth_resume(struct device *dev)
 }
 #endif
 
-static int sh_eth_runtime_nop(struct device *dev)
-{
-       /* Runtime PM callback shared between ->runtime_suspend()
-        * and ->runtime_resume(). Simply returns success.
-        *
-        * This driver re-initializes all registers after
-        * pm_runtime_get_sync() anyway so there is no need
-        * to save and restore registers here.
-        */
-       return 0;
-}
-
 static const struct dev_pm_ops sh_eth_dev_pm_ops = {
        SET_SYSTEM_SLEEP_PM_OPS(sh_eth_suspend, sh_eth_resume)
-       SET_RUNTIME_PM_OPS(sh_eth_runtime_nop, sh_eth_runtime_nop, NULL)
 };
 #define SH_ETH_PM_OPS (&sh_eth_dev_pm_ops)
 #else