]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
wifi: iwlwifi: reduce verbosity of some logging events
authorGolan Ben Ami <golan.ben.ami@intel.com>
Sun, 5 Mar 2023 12:16:18 +0000 (14:16 +0200)
committerJohannes Berg <johannes.berg@intel.com>
Tue, 7 Mar 2023 16:13:38 +0000 (17:13 +0100)
These are cases in which we'd like to warn that something
unexpected happened but they may not be errors.

Reduce verbosity.

Signed-off-by: Golan Ben Ami <golan.ben.ami@intel.com>
Signed-off-by: Gregory Greenman <gregory.greenman@intel.com>
Link: https://lore.kernel.org/r/20230305124407.5eea0f58a74f.Ifb6b35903a5a452a757bfe50b6a7e58b3fd2ef23@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c
drivers/net/wireless/intel/iwlwifi/mvm/rx.c
drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c

index 48e7376a5fea73d8a2e5981106b454165981167d..8e0bc1f5f6c60d9bfa69e72edb64d037576c95db 100644 (file)
@@ -350,9 +350,9 @@ void iwl_dbg_tlv_alloc(struct iwl_trans *trans, const struct iwl_ucode_tlv *tlv,
 
        ret = dbg_tlv_alloc[tlv_idx](trans, tlv);
        if (ret) {
-               IWL_ERR(trans,
-                       "WRT: Failed to allocate TLV 0x%x, ret %d, (ext=%d)\n",
-                       type, ret, ext);
+               IWL_WARN(trans,
+                        "WRT: Failed to allocate TLV 0x%x, ret %d, (ext=%d)\n",
+                        type, ret, ext);
                goto out_err;
        }
 
index 49ca1e168fc5bc10d50c2360921e88f0f5ace07b..ab9a51375c8ac6f025791b62d11f1903097e20f8 100644 (file)
@@ -190,7 +190,7 @@ static u32 iwl_mvm_set_mac80211_rx_flag(struct iwl_mvm *mvm,
        default:
                /* Expected in monitor (not having the keys) */
                if (!mvm->monitor_on)
-                       IWL_ERR(mvm, "Unhandled alg: 0x%x\n", rx_pkt_status);
+                       IWL_WARN(mvm, "Unhandled alg: 0x%x\n", rx_pkt_status);
        }
 
        return 0;
index ba9f79ada82f7e7c6c3931392764fe97f40e8650..2db4f68becff2b32feccaef0c3dd212bfbeecc33 100644 (file)
@@ -444,7 +444,7 @@ static int iwl_mvm_rx_crypto(struct iwl_mvm *mvm, struct ieee80211_sta *sta,
                 */
                if (!is_multicast_ether_addr(hdr->addr1) &&
                    !mvm->monitor_on && net_ratelimit())
-                       IWL_ERR(mvm, "Unhandled alg: 0x%x\n", status);
+                       IWL_WARN(mvm, "Unhandled alg: 0x%x\n", status);
        }
 
        return 0;