]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
soc: qcom: smem: Simplify code with dev_err_probe()
authorZhang Zekun <zhangzekun11@huawei.com>
Mon, 9 Sep 2024 12:29:20 +0000 (20:29 +0800)
committerBjorn Andersson <andersson@kernel.org>
Tue, 29 Oct 2024 20:04:31 +0000 (15:04 -0500)
Use dev_err_probe() directly in the driver probe phase, and we
don't need to judge if the error code is not equal to -EPROBE_DEFER.
This can simplify the code a bit.

Signed-off-by: Zhang Zekun <zhangzekun11@huawei.com>
Link: https://lore.kernel.org/r/20240909122921.12627-4-zhangzekun11@huawei.com
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
drivers/soc/qcom/smem.c

index 0d1ccf3ef1086ce20c497cbe78015d1a8a69038c..cfe358a944717cb7e2837ae4cb577948a7a024b1 100644 (file)
@@ -1186,11 +1186,9 @@ static int qcom_smem_probe(struct platform_device *pdev)
        }
 
        hwlock_id = of_hwspin_lock_get_id(pdev->dev.of_node, 0);
-       if (hwlock_id < 0) {
-               if (hwlock_id != -EPROBE_DEFER)
-                       dev_err(&pdev->dev, "failed to retrieve hwlock\n");
-               return hwlock_id;
-       }
+       if (hwlock_id < 0)
+               return dev_err_probe(&pdev->dev, hwlock_id,
+                                    "failed to retrieve hwlock\n");
 
        smem->hwlock = hwspin_lock_request_specific(hwlock_id);
        if (!smem->hwlock)