]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
test-keyval: Tighten test of trailing crap after size
authorMarkus Armbruster <armbru@redhat.com>
Mon, 25 Nov 2019 13:38:46 +0000 (14:38 +0100)
committerLaurent Vivier <laurent@vivier.eu>
Wed, 18 Dec 2019 11:28:44 +0000 (12:28 +0100)
test_keyval_visit_size() should test for trailing crap after size with
and without suffix.  It does test the latter: "sz2=16Gi" has size
"16G" followed by crap "i".  It fails to test the former "sz1=16E" is
a syntactically valid size that overflows uint64_t.  Replace by
"sz1=0Z".

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20191125133846.27790-3-armbru@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
tests/test-keyval.c

index 09b0ae3c68fb3c30e9fd3cd3774763fbaae7e83d..e331a84149d3bfbb65aaca3c813f218fcf9d1dd2 100644 (file)
@@ -478,7 +478,7 @@ static void test_keyval_visit_size(void)
     visit_free(v);
 
     /* Trailing crap */
-    qdict = keyval_parse("sz1=16E,sz2=16Gi", NULL, &error_abort);
+    qdict = keyval_parse("sz1=0Z,sz2=16Gi", NULL, &error_abort);
     v = qobject_input_visitor_new_keyval(QOBJECT(qdict));
     qobject_unref(qdict);
     visit_start_struct(v, NULL, NULL, 0, &error_abort);