]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commitdiff
Fix regression by Do not skip prologue for asm (.S) files
authorYao Qi <yao.qi@linaro.org>
Wed, 2 Dec 2015 09:32:34 +0000 (09:32 +0000)
committerYao Qi <yao.qi@linaro.org>
Wed, 2 Dec 2015 09:32:34 +0000 (09:32 +0000)
Patch "Do not skip prologue for asm (.S) files" [1] changes GDB's
behaviour on which test gdb.arch/thumb-singlestep.exp depends, so
it causes the fail below:

 (gdb) si^M
 37              blx     foo^M
 (gdb) FAIL: gdb.arch/thumb-singlestep.exp: step into foo

the test assumes the program will stop at the instruction after "push"
but it doesn't.  The fix to this fail is to do one more single step.

[1] https://sourceware.org/ml/gdb-patches/2015-06/msg00561.html

gdb/testsuite:

2015-12-02  Yao Qi  <yao.qi@linaro.org>

* gdb.arch/thumb-singlestep.exp: Do one more single step.

gdb/testsuite/ChangeLog
gdb/testsuite/gdb.arch/thumb-singlestep.exp

index 12754fc795d144ca93e70da7caa8fecb4d0ae9dd..dd253e3b06c603b1518cce5a80cebd5cdf02085b 100644 (file)
@@ -1,3 +1,7 @@
+2015-12-02  Yao Qi  <yao.qi@linaro.org>
+
+       * gdb.arch/thumb-singlestep.exp: Do one more single step.
+
 2015-08-21  Gary Benson <gbenson@redhat.com>
 
        * gdb.trace/pending.exp: Cope with remote transfer warnings.
index 07adaaf3b2d1178b3775f3544571c557d12951e1..e7a865f263658d28521bd416d2c2c46c97136eb6 100644 (file)
@@ -34,5 +34,8 @@ if ![runto_main] then {
     return -1
 }
 
+# GDB doesn't skip prologue for asm files, so do one single step to
+# pass instruction "push".
+gdb_test "si" "blx     foo.*" "single step"
 gdb_test "si" "foo \\(\\) at .*${srcfile}.*mov r0,#42.*" "step into foo"