Prevent a possible NULL de-reference and an unneeded variable assignment.

Found using Clang's static analyzer.

diff --git a/Modules/datetimemodule.c b/Modules/datetimemodule.c
index 402dae9cd95d5404a66be61c8b9685e9ac687281..fa7ef0b71b32a40c91c9e1c42d9a2f85e7ecfea1 100644 (file)
--- a/Modules/datetimemodule.c
+++ b/Modules/datetimemodule.c
@@ -1520,7 +1520,7 @@ delta_to_microseconds(PyDateTime_Delta *self)
                goto Done;
        Py_DECREF(x1);
        Py_DECREF(x2);
-       x1 = x2 = NULL;
+       x2 = NULL;
 
        /* x3 has days+seconds in seconds */
        x1 = PyNumber_Multiply(x3, us_per_second);      /* us */
@@ -3952,7 +3952,7 @@ datetime_strptime(PyObject *cls, PyObject *args)
                        else
                                good_timetuple = 0;
                        /* follow that up with a little dose of microseconds */
-                       if (PyInt_Check(frac))
+                       if (good_timetuple && PyInt_Check(frac))
                                ia[6] = PyInt_AsLong(frac);
                        else
                                good_timetuple = 0;