]> git.ipfire.org Git - thirdparty/git.git/commitdiff
t6300: drop newline from wrapped test title
authorJeff King <peff@peff.net>
Mon, 9 Sep 2024 23:08:41 +0000 (19:08 -0400)
committerJunio C Hamano <gitster@pobox.com>
Mon, 9 Sep 2024 23:26:09 +0000 (16:26 -0700)
We don't usually include newlines in test titles, because you get funny
TAP output like:

  ok 417 - show good signature with custom format
  ok 418 - show good signature with custom format
       with ssh
  ok 419 - signature atom with grade option and bad signature

where a TAP parser would ignore the extra line anyway, giving the wrong
title. This comes from 26c9c03f0a (ref-filter: add new "signature" atom,
2023-06-04), and I think it was probably just editor line wrapping.

I checked for other cases with:

  git grep "test_expect_success [A-Z_,]* '[^']*$"
  git grep 'test_expect_success [A-Z_,]* "[^"]*$'

but this was the only hit.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t6300-for-each-ref.sh

index 8d15713cc6709cfa9b8f962369f25855d6e71c12..7c208e20a692597773d7e6c2f5ffac380e87c4a4 100755 (executable)
@@ -2003,8 +2003,7 @@ test_expect_success GPG 'show good signature with custom format' '
                --format="$GRADE_FORMAT" >actual &&
        test_cmp expect actual
 '
-test_expect_success GPGSSH 'show good signature with custom format
-                           with ssh' '
+test_expect_success GPGSSH 'show good signature with custom format with ssh' '
        test_config gpg.ssh.allowedSignersFile "${GPGSSH_ALLOWED_SIGNERS}" &&
        FINGERPRINT=$(ssh-keygen -lf "${GPGSSH_KEY_PRIMARY}" | awk "{print \$2;}") &&
        cat >expect.tmpl <<-\EOF &&