]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
cifs: Fix FALLOC_FL_INSERT_RANGE by setting i_size after EOF moved
authorDavid Howells <dhowells@redhat.com>
Wed, 29 Nov 2023 16:56:18 +0000 (16:56 +0000)
committerSteve French <stfrench@microsoft.com>
Thu, 30 Nov 2023 01:59:49 +0000 (19:59 -0600)
Fix the cifs filesystem implementations of FALLOC_FL_INSERT_RANGE, in
smb3_insert_range(), to set i_size after extending the file on the server
and before we do the copy to open the gap (as we don't clean up the EOF
marker if the copy fails).

Fixes: 7fe6fe95b936 ("cifs: add FALLOC_FL_INSERT_RANGE support")
Cc: stable@vger.kernel.org
Signed-off-by: David Howells <dhowells@redhat.com>
Acked-by: Paulo Alcantara <pc@manguebit.com>
cc: Shyam Prasad N <nspmangalore@gmail.com>
cc: Rohith Surabattula <rohiths.msft@gmail.com>
cc: Jeff Layton <jlayton@kernel.org>
cc: linux-cifs@vger.kernel.org
cc: linux-mm@kvack.org
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/client/smb2ops.c

index f1b0b2b11ab23be7d973f8875f8a0ceff72e15d3..45931115f475f0b9ea74769f620140af08726e9a 100644 (file)
@@ -3745,6 +3745,9 @@ static long smb3_insert_range(struct file *file, struct cifs_tcon *tcon,
        if (rc < 0)
                goto out_2;
 
+       truncate_setsize(inode, old_eof + len);
+       fscache_resize_cookie(cifs_inode_cookie(inode), i_size_read(inode));
+
        rc = smb2_copychunk_range(xid, cfile, cfile, off, count, off + len);
        if (rc < 0)
                goto out_2;