]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
arm: dts: aspeed: tyan s8036: Enable kcs interrupts
authorAli El-Haj-Mahmoud <aaelhaj@google.com>
Wed, 18 Jan 2023 15:00:30 +0000 (10:00 -0500)
committerJoel Stanley <joel@jms.id.au>
Fri, 27 Jan 2023 00:10:59 +0000 (10:40 +1030)
When the BIOS is built with kcs interrupts enabled, not enabling
interrupts on the BMC results in very poor IPMI performance.
The other way around (BIOS with interrupts disabled, BMC with
interrupts enabled) doesn't suffer degraded IPMI performance.
Enabling interrupts on the BMC covers both scenarios, and should
be the default.

TESTED: manually verified IPMI performance when BIOS is built with and
without KCS interrupts.

Signed-off-by: Ali El-Haj-Mahmoud <aaelhaj@google.com>
Link: https://lore.kernel.org/r/20230118150030.2079226-1-aaelhaj@google.com
Signed-off-by: Joel Stanley <joel@jms.id.au>
arch/arm/boot/dts/aspeed-bmc-tyan-s8036.dts

index 708ee78e4b83066ef453e4b35863bed23cdf8fa5..f6c4549c0ac47a584235d648328d1b633d1aa65d 100644 (file)
 &kcs3 {
        status = "okay";
        aspeed,lpc-io-reg = <0xca2>;
+       aspeed,lpc-interrupts = <1 IRQ_TYPE_LEVEL_HIGH>;
 };
 
 /* Enable BMC VGA output to show an early (pre-BIOS) boot screen */