]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: i2c: imx214: Separate legacy link frequency check from PLL calculation
authorAndré Apitzsch <git@apitzsch.eu>
Mon, 30 Jun 2025 19:05:25 +0000 (21:05 +0200)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Mon, 25 Aug 2025 13:40:39 +0000 (15:40 +0200)
Make it easier to drop the legacy support from the driver later.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: André Apitzsch <git@apitzsch.eu>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/i2c/imx214.c

index cb630d0880109a1ca153722058e85da1e0281027..94ebe625c9e6ee0fb67fe1d89b48b2f1bf58ffc6 100644 (file)
@@ -1362,18 +1362,16 @@ static int imx214_parse_fwnode(struct imx214 *imx214)
                u64 freq = bus_cfg->link_frequencies[i];
                struct ccs_pll pll;
 
-               if (!imx214_pll_calculate(imx214, &pll, freq))
-                       break;
                if (freq == IMX214_DEFAULT_LINK_FREQ_LEGACY) {
                        dev_warn(dev,
                                 "link-frequencies %d not supported, please review your DT. Continuing anyway\n",
                                 IMX214_DEFAULT_LINK_FREQ);
                        freq = IMX214_DEFAULT_LINK_FREQ;
-                       if (imx214_pll_calculate(imx214, &pll, freq))
-                               continue;
                        bus_cfg->link_frequencies[i] = freq;
-                       break;
                }
+
+               if (!imx214_pll_calculate(imx214, &pll, freq))
+                       break;
        }
 
        if (i == bus_cfg->nr_of_link_frequencies)