Coverity:

1469603 Uninitialized scalar field
1445929 Uninitialized scalar field

diff --git a/pdns/recpacketcache.cc b/pdns/recpacketcache.cc
index 8d68e10c58652f6ae80fcf5432f6b2708fdb8d5c..4e15cbed078f92cf3eb75126df82815df1fb3631 100644 (file)
--- a/pdns/recpacketcache.cc
+++ b/pdns/recpacketcache.cc
@@ -177,14 +177,7 @@ void RecursorPacketCache::insertResponsePacket(unsigned int tag, uint32_t qhash,
     return;
   }
 
-  struct Entry e(qname, std::move(responsePacket), std::move(query), tcp);
-  e.d_qhash = qhash;
-  e.d_type = qtype;
-  e.d_class = qclass;
-  e.d_ttd = now + ttl;
-  e.d_creation = now;
-  e.d_tag = tag;
-  e.d_vstate = valState;
+  struct Entry e(qname, qtype, qclass, std::move(responsePacket), std::move(query), tcp, qhash, now + ttl, now, tag, valState);
   if (pbdata) {
     e.d_pbdata = std::move(*pbdata);
   }

diff --git a/pdns/recpacketcache.hh b/pdns/recpacketcache.hh
index 2ffdabfbecdf98cbd8b78ab20b87faf546959ff4..ce238a0546836a6246dbaee1460a8c6bc7da8da5 100644 (file)
--- a/pdns/recpacketcache.hh
+++ b/pdns/recpacketcache.hh
@@ -97,8 +97,10 @@ private:
   };
   struct Entry
   {
-    Entry(const DNSName& qname, std::string&& packet, std::string&& query, bool tcp) :
-      d_name(qname), d_packet(std::move(packet)), d_query(std::move(query)), d_tcp(tcp)
+    Entry(const DNSName& qname, uint16_t qtype, uint16_t qclass, std::string&& packet, std::string&& query, bool tcp,
+          uint32_t qhash, time_t ttd, time_t now, uint32_t tag, vState vstate) :
+      d_name(qname), d_packet(std::move(packet)), d_query(std::move(query)), d_ttd(ttd), d_creation(now),
+      d_qhash(qhash), d_tag(tag), d_type(qtype), d_class(qclass), d_vstate(vstate), d_tcp(tcp)
     {
     }
 

diff --git a/pdns/recursor_cache.hh b/pdns/recursor_cache.hh
index 56c6991914b4fb1b747b71d12c699937f0afde27..bdeca9bb27b5e0f82ff1b246dedebee6e51ce3a3 100644 (file)
--- a/pdns/recursor_cache.hh
+++ b/pdns/recursor_cache.hh
@@ -73,7 +73,7 @@ private:
   struct CacheEntry
   {
     CacheEntry(const std::tuple<DNSName, QType, OptTag, Netmask>& key, bool auth) :
-      d_qname(std::get<0>(key)), d_netmask(std::get<3>(key).getNormalized()), d_rtag(std::get<2>(key)), d_state(vState::Indeterminate), d_ttd(0), d_qtype(std::get<1>(key)), d_auth(auth), d_submitted(false)
+      d_qname(std::get<0>(key)), d_netmask(std::get<3>(key).getNormalized()), d_rtag(std::get<2>(key)), d_state(vState::Indeterminate), d_ttd(0), d_orig_ttl{0}, d_qtype(std::get<1>(key)), d_auth(auth), d_submitted(false)
     {
     }