]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
Add a constant time flag to one of the bignums to avoid a timing leak.
authorPauli <paul.dale@oracle.com>
Wed, 31 Oct 2018 22:44:11 +0000 (08:44 +1000)
committerPauli <paul.dale@oracle.com>
Thu, 1 Nov 2018 22:18:20 +0000 (08:18 +1000)
Reviewed-by: Tim Hudson <tjh@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/7549)

(cherry picked from commit 00496b6423605391864fbbd1693f23631a1c5239)

crypto/dsa/dsa_ossl.c

index 80daf604183a6ce097d2e8103c5be2130e306d75..c887c3c34e37124f3527650d1a88d922d57532f8 100644 (file)
@@ -295,9 +295,9 @@ static int dsa_sign_setup(DSA *dsa, BN_CTX *ctx_in, BIGNUM **kinvp,
 
     if ((dsa->flags & DSA_FLAG_NO_EXP_CONSTTIME) == 0) {
         BN_set_flags(&k, BN_FLG_CONSTTIME);
+        BN_set_flags(&l, BN_FLG_CONSTTIME);
     }
 
-
     if (dsa->flags & DSA_FLAG_CACHE_MONT_P) {
         if (!BN_MONT_CTX_set_locked(&dsa->method_mont_p,
                                     CRYPTO_LOCK_DSA, dsa->p, ctx))