]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
zonefs: set FMODE_CAN_ODIRECT instead of a dummy direct_IO method
authorChristoph Hellwig <hch@lst.de>
Mon, 12 Jun 2023 05:35:15 +0000 (07:35 +0200)
committerDamien Le Moal <dlemoal@kernel.org>
Tue, 13 Jun 2023 23:51:18 +0000 (08:51 +0900)
Since commit a2ad63daa88b ("VFS: add FMODE_CAN_ODIRECT file flag") file
systems can just set the FMODE_CAN_ODIRECT flag at open time instead of
wiring up a dummy direct_IO method to indicate support for direct I/O.
Do that for zonefs so that noop_direct_IO can eventually be removed.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
fs/zonefs/file.c

index c34ec5b540539a669263b8ffea27a228d6024886..d11b08d5e4d1bff51e5ac7dc0821e43844b1f739 100644 (file)
@@ -181,7 +181,6 @@ const struct address_space_operations zonefs_file_aops = {
        .migrate_folio          = filemap_migrate_folio,
        .is_partially_uptodate  = iomap_is_partially_uptodate,
        .error_remove_page      = generic_error_remove_page,
-       .direct_IO              = noop_direct_IO,
        .swap_activate          = zonefs_swap_activate,
 };
 
@@ -815,6 +814,7 @@ static int zonefs_file_open(struct inode *inode, struct file *file)
 {
        int ret;
 
+       file->f_mode |= FMODE_CAN_ODIRECT;
        ret = generic_file_open(inode, file);
        if (ret)
                return ret;