]> git.ipfire.org Git - thirdparty/git.git/commitdiff
refs/packet: add missing BUG() invocations to reflog callbacks
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>
Tue, 20 Jul 2021 10:24:06 +0000 (12:24 +0200)
committerJunio C Hamano <gitster@pobox.com>
Fri, 20 Aug 2021 02:06:38 +0000 (19:06 -0700)
In e0cc8ac8202 (packed_ref_store: make class into a subclass of
`ref_store`, 2017-06-23) a die() was added to packed_create_reflog(),
but not to any of the other reflog callbacks, let's do that.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
refs/packed-backend.c

index f8aa97d7998ecb2db1e677337b3d04eb052e86a8..24a360b719ff258717004100e5ad32a38a5f4811 100644 (file)
@@ -1600,6 +1600,7 @@ static int packed_for_each_reflog_ent(struct ref_store *ref_store,
                                      const char *refname,
                                      each_reflog_ent_fn fn, void *cb_data)
 {
+       BUG("packed reference store does not support reflogs");
        return 0;
 }
 
@@ -1608,12 +1609,14 @@ static int packed_for_each_reflog_ent_reverse(struct ref_store *ref_store,
                                              each_reflog_ent_fn fn,
                                              void *cb_data)
 {
+       BUG("packed reference store does not support reflogs");
        return 0;
 }
 
 static int packed_reflog_exists(struct ref_store *ref_store,
                               const char *refname)
 {
+       BUG("packed reference store does not support reflogs");
        return 0;
 }
 
@@ -1627,6 +1630,7 @@ static int packed_create_reflog(struct ref_store *ref_store,
 static int packed_delete_reflog(struct ref_store *ref_store,
                               const char *refname)
 {
+       BUG("packed reference store does not support reflogs");
        return 0;
 }
 
@@ -1638,6 +1642,7 @@ static int packed_reflog_expire(struct ref_store *ref_store,
                                reflog_expiry_cleanup_fn cleanup_fn,
                                void *policy_cb_data)
 {
+       BUG("packed reference store does not support reflogs");
        return 0;
 }