]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
Use return code for 'which command' checks
authorJon Spillett <jon.spillett@oracle.com>
Thu, 3 Sep 2020 04:02:48 +0000 (14:02 +1000)
committerPauli <paul.dale@oracle.com>
Mon, 7 Sep 2020 23:03:09 +0000 (09:03 +1000)
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from https://github.com/openssl/openssl/pull/12775)

test/recipes/81-test_cmp_cli.t

index 8c4f0f920a50014adec5c762b42283050a53590c..fa70c84981797dcc4564e643b8d816c3f8b515e6 100644 (file)
@@ -37,9 +37,9 @@ plan skip_all => "Tests involving CMP server not available on Windows or VMS"
 plan skip_all => "Tests involving CMP server not available in cross-compile builds"
     if defined $ENV{EXE_SHELL};
 plan skip_all => "Tests involving CMP server require 'kill' command"
-    unless `which kill`;
+    if system("which kill");
 plan skip_all => "Tests involving CMP server require 'lsof' command"
-    unless `which lsof`; # this typically excludes Solaris
+    if system("which lsof"); # this typically excludes Solaris
 
 sub chop_dblquot { # chop any leading & trailing '"' (needed for Windows)
     my $str = shift;