]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commitdiff
[gdb/testsuite] Fix gdb.server/server-connect.exp for missing ipv6
authorTom de Vries <tdevries@suse.de>
Wed, 20 Mar 2024 18:31:24 +0000 (19:31 +0100)
committerTom de Vries <tdevries@suse.de>
Wed, 20 Mar 2024 18:31:24 +0000 (19:31 +0100)
On a system without ipv6 support enabled, when running test-case
gdb.server/server-connect.exp, it takes about 4 minutes, and I get:
...
builtin_spawn gdbserver --once ::1:2347 server-connect^M
Can't open socket: Address family not supported by protocol.^M
Exiting^M
PASS: gdb.server/server-connect.exp: tcp6: start gdbserver
target remote tcp6:::1:2347^M
A program is being debugged already.  Kill it? (y or n) y^M
could not connect: Address family not supported by protocol.^M
(gdb) FAIL: gdb.server/server-connect.exp: tcp6: connect to gdbserver using tcp6:::1
...

Fix this by:
- recognizing the error message in gdbserver_start, and returning an empty list
  to signal unsupported, and
- handling the unsupported response in the test-case.

This brings testing time down to 2 seconds, and gets me:
...
UNSUPPORTED: gdb.server/server-connect.exp: tcp6: start gdbserver
UNSUPPORTED: gdb.server/server-connect.exp: tcp6-with-brackets: start gdbserver
UNSUPPORTED: gdb.server/server-connect.exp: udp6: start gdbserver
UNSUPPORTED: gdb.server/server-connect.exp: udp6-with-brackets: start gdbserver
...

Tested on aarch64-linux.

Approved-By: Tom Tromey <tom@tromey.com>
PR testsuite/31502
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31502

gdb/testsuite/gdb.server/server-connect.exp
gdb/testsuite/lib/gdbserver-support.exp

index dd81585a79665287d5e8721e49feaaa8db7e8a8d..7617da66acde803e0d5de16f439099fcb469dab1 100644 (file)
@@ -88,6 +88,9 @@ save_vars { GDB_TEST_SOCKETHOST } {
            } else {
                if { $gdbserver_should_fail } {
                    fail "$test: gdbserver should fail but did not"
+               } elseif { [llength $res] == 0 } {
+                   unsupported $test
+                   continue
                } else {
                    pass "$test"
                }
index e8ab057647da4c3ab3caaadee983f23961cced91..727a66e2ab1e3eefff64ea68b010e78481e81895 100644 (file)
@@ -382,6 +382,9 @@ proc gdbserver_start { options arguments } {
            -re ".*: cannot resolve name: .*\r\n" {
                error "gdbserver cannot resolve name."
            }
+           -re "Can't open socket: Address family not supported by protocol." {
+               return {}
+           }
            timeout {
                error "Timeout waiting for gdbserver response."
            }