]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
f2fs: compress: fix zstd data corruption
authorChao Yu <yuchao0@huawei.com>
Fri, 8 May 2020 01:16:03 +0000 (09:16 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 24 Jun 2020 15:48:43 +0000 (17:48 +0200)
[ Upstream commit 1454c978efbb57b052670d50023f48c759d704ce ]

During zstd compression, ZSTD_endStream() may return non-zero value
because distination buffer is full, but there is still compressed data
remained in intermediate buffer, it means that zstd algorithm can not
save at last one block space, let's just writeback raw data instead of
compressed one, this can fix data corruption when decompressing
incomplete stored compression data.

Fixes: 50cfa66f0de0 ("f2fs: compress: support zstd compress algorithm")
Signed-off-by: Daeho Jeong <daehojeong@google.com>
Signed-off-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/f2fs/compress.c

index c05801758a3587c8f791e264f98302ca158ab774..a5b2e72174bb1f6add00e6f684e3855e95561efa 100644 (file)
@@ -369,6 +369,13 @@ static int zstd_compress_pages(struct compress_ctx *cc)
                return -EIO;
        }
 
+       /*
+        * there is compressed data remained in intermediate buffer due to
+        * no more space in cbuf.cdata
+        */
+       if (ret)
+               return -EAGAIN;
+
        cc->clen = outbuf.pos;
        return 0;
 }