]> git.ipfire.org Git - thirdparty/git.git/commitdiff
help: fix leaking `struct cmdnames`
authorPatrick Steinhardt <ps@pks.im>
Wed, 20 Nov 2024 13:39:44 +0000 (14:39 +0100)
committerJunio C Hamano <gitster@pobox.com>
Wed, 20 Nov 2024 23:23:44 +0000 (08:23 +0900)
We're populating multiple `struct cmdnames`, but don't ever free them.
Plug this memory leak.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
help.c

diff --git a/help.c b/help.c
index 8794f81db9bbf457b7cabca59222299922f3cc7f..8b56cd6e25ba5f2be2cbf2a7a9ed48136e12a0c7 100644 (file)
--- a/help.c
+++ b/help.c
@@ -723,6 +723,10 @@ const char *help_unknown_cmd(const char *cmd)
                                   (float)cfg.autocorrect/10.0, assumed);
                        sleep_millisec(cfg.autocorrect * 100);
                }
+
+               cmdnames_release(&cfg.aliases);
+               cmdnames_release(&main_cmds);
+               cmdnames_release(&other_cmds);
                return assumed;
        }