]> git.ipfire.org Git - thirdparty/git.git/commitdiff
ls-tree: rename "retval" to "recurse" in "show_tree()"
authorTeng Long <dyroneteng@gmail.com>
Wed, 23 Mar 2022 09:13:06 +0000 (17:13 +0800)
committerJunio C Hamano <gitster@pobox.com>
Wed, 23 Mar 2022 18:38:39 +0000 (11:38 -0700)
The variable which "show_tree()" return is named "retval", a name that's
a little hard to understand. The commit rename "retval" to "recurse"
which is a more meaningful name than before in the context. We do not
need to take a look at "read_tree_at()" in "tree.c" to make sure what
does "retval" mean.

Signed-off-by: Teng Long <dyroneteng@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/ls-tree.c

index eecc7482d54814a65667324ea196bf6cb71b537b..ef8c414f61abe37fa8e8db1e30fd747a95768eef 100644 (file)
@@ -64,7 +64,7 @@ static int show_recursive(const char *base, size_t baselen, const char *pathname
 static int show_tree(const struct object_id *oid, struct strbuf *base,
                const char *pathname, unsigned mode, void *context)
 {
-       int retval = 0;
+       int recurse = 0;
        size_t baselen;
        enum object_type type = OBJ_BLOB;
 
@@ -72,9 +72,9 @@ static int show_tree(const struct object_id *oid, struct strbuf *base,
                type = OBJ_COMMIT;
        } else if (S_ISDIR(mode)) {
                if (show_recursive(base->buf, base->len, pathname)) {
-                       retval = READ_TREE_RECURSIVE;
+                       recurse = READ_TREE_RECURSIVE;
                        if (!(ls_options & LS_SHOW_TREES))
-                               return retval;
+                               return recurse;
                }
                type = OBJ_TREE;
        }
@@ -109,7 +109,7 @@ static int show_tree(const struct object_id *oid, struct strbuf *base,
                                   chomp_prefix ? ls_tree_prefix : NULL,
                                   stdout, line_termination);
        strbuf_setlen(base, baselen);
-       return retval;
+       return recurse;
 }
 
 int cmd_ls_tree(int argc, const char **argv, const char *prefix)