builtin.h: remove unneccessary includes

This also made it clear that a few .c files under builtin/ were
depending upon some headers but had forgotten to #include them.  Add the
missing direct includes while at it.

Signed-off-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/builtin.h b/builtin.h
index 3e6c22eef69ea92fd7f8ada81f552e18c6a11e43..d560baa6618ac9e021dc7f957b942466ac6e35b3 100644 (file)
--- a/builtin.h
+++ b/builtin.h
@@ -2,8 +2,6 @@
 #define BUILTIN_H
 
 #include "git-compat-util.h"
-#include "strbuf.h"
-#include "commit.h"
 
 /*
  * builtin API

diff --git a/builtin/check-mailmap.c b/builtin/check-mailmap.c
index 002d2941e931034f9426c8e3dbda28310fc2776a..b8a05b8e07b523953dfe9e8d6e572346a27d7791 100644 (file)
--- a/builtin/check-mailmap.c
+++ b/builtin/check-mailmap.c
@@ -4,6 +4,7 @@
 #include "ident.h"
 #include "mailmap.h"
 #include "parse-options.h"
+#include "strbuf.h"
 #include "string-list.h"
 #include "write-or-die.h"
 

diff --git a/builtin/commit-graph.c b/builtin/commit-graph.c
index a3d00fa232b51a0ed6581a2638ca65bf50db3023..96a8a67732777f291bcd491efbfcc57c2a72b01f 100644 (file)
--- a/builtin/commit-graph.c
+++ b/builtin/commit-graph.c
@@ -1,4 +1,5 @@
 #include "builtin.h"
+#include "commit.h"
 #include "config.h"
 #include "dir.h"
 #include "environment.h"

diff --git a/builtin/config.c b/builtin/config.c
index d40fddb042a6cc34000f0135b1ccb60f284a3e18..6599f88b24357613702863761914c660615290ec 100644 (file)
--- a/builtin/config.c
+++ b/builtin/config.c
@@ -13,6 +13,7 @@
 #include "path.h"
 #include "quote.h"
 #include "setup.h"
+#include "strbuf.h"
 #include "worktree.h"
 #include "wrapper.h"
 

diff --git a/builtin/credential-cache.c b/builtin/credential-cache.c
index 0ffacfdd83c94f31910980c45f206c5963965894..ff3a47badbeecc6d019d0d189f1764297978c79b 100644 (file)
--- a/builtin/credential-cache.c
+++ b/builtin/credential-cache.c
@@ -2,6 +2,7 @@
 #include "gettext.h"
 #include "parse-options.h"
 #include "path.h"
+#include "strbuf.h"
 #include "wrapper.h"
 #include "write-or-die.h"
 

diff --git a/builtin/for-each-ref.c b/builtin/for-each-ref.c
index d0d6ab0fd3453c323bafabe09cd47ffee8e5aa82..15409337f833e27d1bba47124b3dfec102fbb10b 100644 (file)
--- a/builtin/for-each-ref.c
+++ b/builtin/for-each-ref.c
@@ -5,6 +5,7 @@
 #include "object.h"
 #include "parse-options.h"
 #include "ref-filter.h"
+#include "strbuf.h"
 #include "strvec.h"
 #include "commit-reach.h"
 

diff --git a/builtin/init-db.c b/builtin/init-db.c
index 680ef7e183796592070c3eb66696898ccb398428..0d8bd4d72192f275f894fa983aa307df0cae2b7a 100644 (file)
--- a/builtin/init-db.c
+++ b/builtin/init-db.c
@@ -12,6 +12,7 @@
 #include "parse-options.h"
 #include "path.h"
 #include "setup.h"
+#include "strbuf.h"
 #include "wrapper.h"
 
 static int guess_repository_type(const char *git_dir)

diff --git a/builtin/verify-pack.c b/builtin/verify-pack.c
index aba92cf8af7325630996c31f051aa2e22a1cfff6..011dddd2dc329292c363fbcfb10b71c218ffa034 100644 (file)
--- a/builtin/verify-pack.c
+++ b/builtin/verify-pack.c
@@ -3,6 +3,7 @@
 #include "gettext.h"
 #include "run-command.h"
 #include "parse-options.h"
+#include "strbuf.h"
 
 #define VERIFY_PACK_VERBOSE 01
 #define VERIFY_PACK_STAT_ONLY 02