]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
tests: storage hardcoding paths for mount & vgchange
authorDaniel P. Berrangé <berrange@redhat.com>
Mon, 28 Apr 2025 10:43:30 +0000 (11:43 +0100)
committerDaniel P. Berrangé <berrange@redhat.com>
Fri, 2 May 2025 08:31:27 +0000 (09:31 +0100)
This is redundant since the tests will strip any path component from the
binary name before comparison.

Reviewed-by: Peter Krempa <pkrempa@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
tests/storagepoolxml2argvtest.c

index e8e40d695ee6057b9b39aec38edefe650c3cc4b4..d5c2531ab876008bdc0fc0455d492f4535b11f88 100644 (file)
@@ -6,14 +6,6 @@
 
 #define VIR_FROM_THIS VIR_FROM_NONE
 
-#ifndef MOUNT
-# define MOUNT "/usr/bin/mount"
-#endif
-
-#ifndef VGCHANGE
-# define VGCHANGE "/usr/sbin/vgchange"
-#endif
-
 static int
 testCompareXMLToArgvFiles(bool shouldFail,
                           const char *poolxml,
@@ -46,12 +38,12 @@ testCompareXMLToArgvFiles(bool shouldFail,
             goto cleanup;
         }
 
-        cmd = virStorageBackendFileSystemMountCmd(MOUNT, def, src);
+        cmd = virStorageBackendFileSystemMountCmd("mount", def, src);
         def = NULL;
         break;
 
     case VIR_STORAGE_POOL_LOGICAL:
-        cmd = virStorageBackendLogicalChangeCmd(VGCHANGE, def, true);
+        cmd = virStorageBackendLogicalChangeCmd("vgchange", def, true);
         break;
 
     case VIR_STORAGE_POOL_DIR: