]> git.ipfire.org Git - thirdparty/asterisk.git/commitdiff
app_queue: fix comparison for announce-position-only-up
authorStuart Henderson <sthen@users.noreply.github.com>
Thu, 21 Aug 2025 10:22:40 +0000 (10:22 +0000)
committerAsterisk Development Team <asteriskteam@digium.com>
Wed, 10 Sep 2025 19:53:00 +0000 (19:53 +0000)
Numerically comparing that the current queue position is less than
last_pos_said can only be done after at least one announcement has been
made, otherwise last_pos_said is at the default (0).

Fixes: #1386
(cherry picked from commit a32fe8572534f071dbf0a2d2ea9c7c0217426117)

apps/app_queue.c

index d41b76de3dacf774f7c14181838dfa70d88a9ac5..39a2a1750545f65f0ef4edfe8c689851ad70bac6 100644 (file)
@@ -4440,7 +4440,7 @@ static int say_position(struct queue_ent *qe, int ringing)
        }
 
        /* Only announce if the caller's queue position has improved since last time */
-       if (qe->parent->announceposition_only_up && qe->last_pos_said <= qe->pos) {
+       if (qe->parent->announceposition_only_up && qe->last_pos_said > 0 && qe->last_pos_said <= qe->pos) {
                return 0;
        }