]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
btrfs: send: simplify return logic from record_changed_ref()
authorFilipe Manana <fdmanana@suse.com>
Tue, 18 Feb 2025 15:52:22 +0000 (15:52 +0000)
committerDavid Sterba <dsterba@suse.com>
Tue, 18 Mar 2025 19:35:46 +0000 (20:35 +0100)
There is no need to have an 'out' label and jump into it since there are
no resource cleanups to perform (release locks, free memory, etc), so
make this simpler by removing the label and goto and instead return
directly.

Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/send.c

index 6e171b504415cb19d19c61982968a4f4eb466bb4..01b8b570d6ed3dac50684ad05d760137e35be624 100644 (file)
@@ -4766,20 +4766,18 @@ static int record_deleted_ref(struct send_ctx *sctx)
 
 static int record_changed_ref(struct send_ctx *sctx)
 {
-       int ret = 0;
+       int ret;
 
        ret = iterate_inode_ref(sctx->send_root, sctx->left_path,
                        sctx->cmp_key, 0, record_new_ref_if_needed, sctx);
        if (ret < 0)
-               goto out;
+               return ret;
        ret = iterate_inode_ref(sctx->parent_root, sctx->right_path,
                        sctx->cmp_key, 0, record_deleted_ref_if_needed, sctx);
        if (ret < 0)
-               goto out;
-       ret = 0;
+               return ret;
 
-out:
-       return ret;
+       return 0;
 }
 
 /*