]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ext2: Fix i_op setting for special inode
authorChengguang Xu <cgxu519@mykernel.net>
Fri, 22 May 2020 04:40:34 +0000 (12:40 +0800)
committerJan Kara <jack@suse.cz>
Fri, 22 May 2020 12:34:07 +0000 (14:34 +0200)
Let's always set special inode i_op to &ext2_special_inode_operations
regardless of CONFIG_EXT2_FS_XATTR setting. It makes sence to be able to
query extended inode flags (needing ->setattr and ->getattr callbacks)
even when CONFIG_EXT2_FS_XATTR is not set.

Link: https://lore.kernel.org/r/20200522044035.24190-1-cgxu519@mykernel.net
Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
Signed-off-by: Jan Kara <jack@suse.cz>
fs/ext2/namei.c

index ccfbbf59e2fc9cfb4986e8f0c312bb1cf7affb01..1a5421a34ef7f190e68c95233ee4bc488f7812f8 100644 (file)
@@ -136,9 +136,7 @@ static int ext2_mknod (struct inode * dir, struct dentry *dentry, umode_t mode,
        err = PTR_ERR(inode);
        if (!IS_ERR(inode)) {
                init_special_inode(inode, inode->i_mode, rdev);
-#ifdef CONFIG_EXT2_FS_XATTR
                inode->i_op = &ext2_special_inode_operations;
-#endif
                mark_inode_dirty(inode);
                err = ext2_add_nondir(dentry, inode);
        }