]> git.ipfire.org Git - thirdparty/freeradius-server.git/commitdiff
shut up coverity. CID #1604620
authorAlan T. DeKok <aland@freeradius.org>
Sat, 11 Jan 2025 15:11:38 +0000 (10:11 -0500)
committerAlan T. DeKok <aland@freeradius.org>
Sun, 12 Jan 2025 14:51:10 +0000 (09:51 -0500)
src/listen/tacacs/proto_tacacs_tcp.c

index 4493e0bfd6060295c1f6b336cd9d395d93311d17..bebdbaaadf9d008dcd8e1f2190aa54af7abddbcc 100644 (file)
@@ -269,6 +269,7 @@ static ssize_t mod_write(fr_listen_t *li, UNUSED void *packet_ctx, UNUSED fr_tim
         */
        fr_assert(buffer_len >= sizeof(fr_tacacs_packet_hdr_t));
        fr_assert(written < buffer_len);
+       fr_assert(buffer_len < (1 << 20)); /* shut up coverity */
 
        /*
         *      @todo - share a stats interface with the parent?  or
@@ -286,6 +287,8 @@ static ssize_t mod_write(fr_listen_t *li, UNUSED void *packet_ctx, UNUSED fr_tim
        data_size = write(thread->sockfd, buffer + written, buffer_len - written);
        if (data_size <= 0) return data_size;
 
+       fr_assert((size_t) data_size <= buffer_len); /* shut up coverity */
+
        /*
         *      If we're supposed to close the socket, then go do that.
         */