]> git.ipfire.org Git - thirdparty/git.git/commitdiff
http.c: remove unnecessary casts to long
authorTaylor Blau <me@ttaylorr.com>
Wed, 19 Mar 2025 22:23:46 +0000 (18:23 -0400)
committerJunio C Hamano <gitster@pobox.com>
Fri, 21 Mar 2025 08:38:27 +0000 (01:38 -0700)
When parsing 'http.lowSpeedLimit' and 'http.lowSpeedTime', we explicitly
cast the result of 'git_config_int()' to a long before assignment. This
cast has been in place since all the way back in 58e60dd203 (Add support
for pushing to a remote repository using HTTP/DAV, 2005-11-02).

But that cast has always been unnecessary, since long is guaranteed to
be at least as wide as int. Let's drop the cast accordingly.

Noticed-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Taylor Blau <me@ttaylorr.com>
Acked-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
http.c

diff --git a/http.c b/http.c
index 0c9a872809f87228884bea4ca5c2235c8a7dba27..0cbcb079b29542e237be481391ebb8b23320ae29 100644 (file)
--- a/http.c
+++ b/http.c
@@ -438,11 +438,11 @@ static int http_options(const char *var, const char *value,
                return 0;
        }
        if (!strcmp("http.lowspeedlimit", var)) {
-               curl_low_speed_limit = (long)git_config_int(var, value, ctx->kvi);
+               curl_low_speed_limit = git_config_int(var, value, ctx->kvi);
                return 0;
        }
        if (!strcmp("http.lowspeedtime", var)) {
-               curl_low_speed_time = (long)git_config_int(var, value, ctx->kvi);
+               curl_low_speed_time = git_config_int(var, value, ctx->kvi);
                return 0;
        }