Coverity Scan false positives clarifications

diff --git a/daemon/worker.c b/daemon/worker.c
index 63e866103baa3003404140405cebb744e508825b..f161ea95a4b20329c313ef22e63db3256dbda7a8 100644 (file)
--- a/daemon/worker.c
+++ b/daemon/worker.c
@@ -1279,6 +1279,7 @@ static uv_handle_t *transmit(struct qr_task *task)
                struct session *session = ret->data;
                struct sockaddr *peer = session_get_peer(session);
                kr_assert(peer->sa_family == AF_UNSPEC && session_flags(session)->outgoing);
+               kr_require(addr->sa_family == AF_INET || addr->sa_family == AF_INET6);
                memcpy(peer, addr, kr_sockaddr_len(addr));
                if (qr_task_send(task, session, (struct sockaddr *)choice,
                                 task->pktbuf) != 0) {

diff --git a/daemon/zimport.c b/daemon/zimport.c
index 418fb5a8158359b220754acb3d13e2f6fe5d9bed..6bea6811f9fa16c06e70d3e520f50e1c6f55e240 100644 (file)
--- a/daemon/zimport.c
+++ b/daemon/zimport.c
@@ -407,6 +407,9 @@ static void ctx_delete(zone_import_ctx_t *z_import)
 {
        if (kr_fails_assert(z_import)) return;
        kr_svldr_free_ctx(z_import->svldr);
+
+       /* Free `z_import`'s pool, including `z_import` itself, because it is
+        * allocated inside said pool. */
        mm_ctx_delete(z_import->pool);
 }
 static void timer_close(uv_handle_t *handle)